Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address REVIEW comments in CueingArrows #114

Closed
samreid opened this issue Mar 15, 2023 · 3 comments
Closed

Address REVIEW comments in CueingArrows #114

samreid opened this issue Mar 15, 2023 · 3 comments
Assignees
@AgustinVallejo
Labels
dev:code-review status:ready-for-review

Comments

@samreid
Copy link
Member

samreid commented Mar 15, 2023

For #95, there are several code comments in CueingArrows, which we may delete anyways (based on recent interviews).
@samreid samreid self-assigned this Mar 15, 2023
samreid added a commit to phetsims/solar-system-common that referenced this issue Mar 15, 2023
@samreid
Address REVIEW comments in CueingArrowsNode, see phetsims/my-solar-sy…
441daff 
…stem#114
@samreid
Copy link
Member Author

samreid commented Mar 15, 2023 •
edited
Loading

Addressed some REVIEW comments, @AgustinVallejo can you please review?

@samreid samreid assigned AgustinVallejo and unassigned samreid Mar 15, 2023
@samreid
Copy link
Member Author

samreid commented Mar 15, 2023

Maybe also wait until #115 is answered before spending a lot more time in this file.

@samreid
Copy link
Member Author

samreid commented Mar 15, 2023

File deleted in #115, closing.

@samreid samreid closed this as completed Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AgustinVallejo AgustinVallejo

Labels
dev:code-review status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @AgustinVallejo