-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accessible descriptions to this sim #180
Comments
…gs for descriptions, needed for phetsims/molecules-and-light#180
Completed the help text in the above commits. We can review at Up next is handling the alerts. |
We will need to design a description for Methane in the radio button group for #179. |
I noticed this text in the description spreadsheet,
This appears to be a 3rd case for the dynamic text for the Observation Window, so I'm curious if it should be implemented, or if it's a note for further investigation? There's no indication if it should be an alert or help/dynamic text. For now, I'm leaving it off while I handle other alerts. @terracoda thoughts/adivce? |
@mbarlow12 are you referring to cell C9 under Linear Description tab? Where are the other 2 descriptions for the Observation Window? Phrases in C9 are not alerts by my examination. I believe that the 2 cases there are dynamic descriptions and intended to describe the state of the observation window. If the light source is off, you get various possibilities using the phrase for Case 1, and if the light source is on, you get various possibilities of the phrase labeled Case 2. You wouldn't get both at the same time. You probably know that there are three tabs in the spreadsheet, one is titled Alert Description, so I think the alerts are in that tab. Does that help? |
@mbarlow12, the link in #180 (comment) is not working. Could you post a new one when you have time? |
@terracoda It's actually the cell G9 in the 'Notes' column. There's an added placeholder for the rate of photon emission (e.g. {{slow}}) that does not appear in the C9 strings. C9 Case 2: G9 It's unclear if this text is supposed to appear in the html or if it's just a note from the design process/dicsussion. |
Here's the latest dev release: |
@mbarlow12, oh, I see, great question! I am pretty sure the notes column, is just "notes" that you can ignore. I think in this case, the note is a previous iteration. I think you just need either case 1 or case 2 that are actually in cell C9. |
@mbarlow12, I had a quick peak at the a11y view. The content is looking great! Nice work so far! |
Thanks for the clarification @terracoda! Alerts are almost done—they just need some clean up. |
@mbarlow12 can you re-assign me when or if you have questions or you want me to test it? |
@mbarlow12, re #180 (comment), I made a quick stab at Methane, based on the other descriptions. |
Marking deferred until someone is assigned to do this a11y work |
I'm working on a github issue template for tracking A11y design and implementation. |
@Matthew-phet and @zepumph, the issue template may be good enough to try to use with Moleclues and Light. One possible way to move forward, is to you close this issue, and reference it in a new issue that is populated with the checklist. |
@Matthew-phet and @zepumph, I think the issue template is good enough to use, and many things can already be checked off. |
I agree we should close this issue and create a new one to track description progress with the template. |
@Matthew-phet, I'll close this issue and we can continue tracking progress in #201 |
…r and implement a1erts, see phetsims/molecules-and-light#180
We are ready to add accessible descriptions to this sim. Here is a link to the description spreadsheet that defines various descriptions for the sim.
https://docs.google.com/spreadsheets/d/1AwlqM8DUchUunzUHyK63xXIIjVtgkV6Q55oDLlKC9hg/edit#gid=0
@mbarlow12 said he could work on this, thanks!
The text was updated successfully, but these errors were encountered: