Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd interaction between showOuterLonePairsProperty and showLonePairsProperty #228

Closed
Tracked by #237
arouinfar opened this issue Oct 7, 2022 · 6 comments
Closed
Tracked by #237
Assignees
Labels

Comments

@arouinfar
Copy link
Contributor

Related to #223, and relevant history of showOuterLonePairsProperty can be found in #194 and #201.

Steps to reproduce:

  1. Open Molecule Shapes in Studio.
  2. Go to Real Molecules screen and select BrF5, since it has lone pairs on the central and outer atoms.
  3. Set showOuterLonePairsProperty to true. Outer lone pairs appear as expected.
  4. Set showOuterLonePairsProperty to false. All lone pairs disappear, including the one on the central atom. (The central lone pair should be independent of the outer lone pairs.)
  5. Uncheck the Show Lone Pairs checkbox, then turn it back on. The lone pair reappears on the central atom, but a few outer lone pairs also show up.
    image

@jonathanolson unfortunately this isn't consistent. I have two different tabs open in Chrome -- in one tab, I cannot reproduce this at all. In the other tab, I can consistently encounter the described buggy behavior.

Here's the troubleshooting info for the phet-brand version on master:

Troubleshooting information:
!!!!! DO NOT EDIT !!!!!
Name: ‪Molecule Shapes‬
URL: https://bayes.colorado.edu/dev/phettest/molecule-shapes/molecule-shapes_en.html?ea&brand=phet
Version: 1.5.0-dev.3 (unbuilt)
Features missing: applicationcache, applicationcache, touch
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Safari/537.36
Language: en-US
Window: 1793x1329
Pixel Ratio: 1/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 31 uniform: 1024
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 16384x16384
OES_texture_float: true
Dependencies JSON: {}

@arouinfar
Copy link
Contributor Author

Tagging for phetsims/qa#844 and phetsims/qa#845.

@Nancy-Salpepi
Copy link

Nancy-Salpepi commented Oct 21, 2022

For phetsims/qa#844 this also happens in the PhET brand sim.

outerlonepairs.mp4

Screen Shot 2022-10-21 at 8 22 59 AM

@KatieWoe
Copy link
Contributor

Adding on to what Nancy saw, just turning the "Show Lone Pairs" off and on again does this, you don't need to turn outer pairs on or off from what I saw.

@Nancy-Salpepi
Copy link

I saw the same as @KatieWoe-- no need to do steps 3 and 4 to see the outer lone pairs appear when they shouldn't.

The other part of the bug that was reported by @arouinfar also happens in the PhET brand sim:
Checking and unchecking the Show Outer Lone Pairs Checkbox also hides the lone pairs for the central atom when it shouldn't.

@KatieWoe
Copy link
Contributor

Also the bugged pairs seem different when you are in projector mode.
Non projector mode:
dark
Projector mode:
projector

@jonathanolson
Copy link
Contributor

Fix applied in common code above. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants