-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Odd interaction between showOuterLonePairsProperty
and showLonePairsProperty
#228
Comments
Tagging for phetsims/qa#844 and phetsims/qa#845. |
For phetsims/qa#844 this also happens in the PhET brand sim. outerlonepairs.mp4 |
Adding on to what Nancy saw, just turning the "Show Lone Pairs" off and on again does this, you don't need to turn outer pairs on or off from what I saw. |
I saw the same as @KatieWoe-- no need to do steps 3 and 4 to see the outer lone pairs appear when they shouldn't. The other part of the bug that was reported by @arouinfar also happens in the PhET brand sim: |
… partial revert of ccc6b0d
Fix applied in common code above. Closing. |
Related to #223, and relevant history of
showOuterLonePairsProperty
can be found in #194 and #201.Steps to reproduce:
showOuterLonePairsProperty
to true. Outer lone pairs appear as expected.showOuterLonePairsProperty
to false. All lone pairs disappear, including the one on the central atom. (The central lone pair should be independent of the outer lone pairs.)@jonathanolson unfortunately this isn't consistent. I have two different tabs open in Chrome -- in one tab, I cannot reproduce this at all. In the other tab, I can consistently encounter the described buggy behavior.
Here's the troubleshooting info for the phet-brand version on master:
Troubleshooting information:
!!!!! DO NOT EDIT !!!!!
Name: Molecule Shapes
URL: https://bayes.colorado.edu/dev/phettest/molecule-shapes/molecule-shapes_en.html?ea&brand=phet
Version: 1.5.0-dev.3 (unbuilt)
Features missing: applicationcache, applicationcache, touch
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Safari/537.36
Language: en-US
Window: 1793x1329
Pixel Ratio: 1/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 31 uniform: 1024
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 16384x16384
OES_texture_float: true
Dependencies JSON: {}
The text was updated successfully, but these errors were encountered: