Only display outer lone pairs if "Show Outer Lone Pairs" and "Show Lone Pairs" are checked

[Nancy-Salpepi]

The checkbox for 'show outer lone pairs' is currently in the Options dialog found in the PhET menu.
This means that this option is not affected by the Reset All button (and the location seems odd in general).
Perhaps move to Options Panel and couple with 'show loan pairs?'

In studio, I also don't see anywhere in the tree that would change the visible property of the 'Show Outer Lone Pairs' checkbox to hide it from students. All I see is:

which just checks/unchecks the property.

[arouinfar]

Thanks @Nancy-Salpepi!

Show Outer Lone Pairs is a more teacher-facing control. We want teachers to be able to opt-in to showing all lone pairs in the molecule, not just those on the central atom. This is not something we want students to naturally encounter, which is why it's in the Options menu.

That said, I do find it really strange that "Show Lone Pairs" only applies to the lone pairs on the central atom. I would expect it to apply to all lone pairs. If Show Outer Lone Pairs is checked, I want it to respect the state of the Show Lone Pairs checkbox in the sim.

@jonathanolson can change the behavior so that "Show Outer Lone Pairs" will display the outer lone pairs only when the "Show Lone Pairs" checkbox within the sim is checked?

In studio, I also don't see anywhere in the tree that would change the visible property of the 'Show Outer Lone Pairs' checkbox to hide it from students. All I see is:

@Nancy-Salpepi you can find the Options Dialog content in the tree under moleculeShapes.general.view.navigationBar.phetButton.phetMenu.optionsDialogCapsule.optionsDialog.content.

[jonathanolson]

Implemented above, @arouinfar can you verify?

[arouinfar]

Thanks @jonathanolson it looks like all lone pairs respect the "Show Lone Pairs" checkbox within the sim. However, something strange is going on with the enabledProperty of the checkbox itself. The "Show Lone Pairs" checkbox is only enabled for molecules that have lone pairs on the central atom. This can lead to odd situations where there are lone pairs in the molecule, but the checkbox is disabled (such as CO2 or BF3).

In my opinion, it's not necessary to disable the checkbox for molecules that do not contain lone pairs. Can you instead leave "Show Lone Pairs" always enabled regardless of the selected molecule?

[jonathanolson]

Changed above, can you verify?

[arouinfar]

Looks good in master, thanks @jonathanolson. Not sure if you want this verified in the next QA cycle too or not, so back to you.

[jonathanolson]

I'm fine closing, thanks!