TODOs for #140

phetsims · Aug 31, 2022 · ec4dcd1 · ec4dcd1
1 parent 70adb47
commit ec4dcd1
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 0 deletions.
diff --git a/js/common/view/DipoleDirectionRadioButtonGroup.js b/js/common/view/DipoleDirectionRadioButtonGroup.js
@@ -39,12 +39,14 @@ class DipoleDirectionRadioButtonGroup extends AquaRadioButtonGroup {
     }, MPConstants.AQUA_RADIO_BUTTON_OPTIONS, options );
 
     // d+ -> d-
+    //TODO https://github.com/phetsims/molecule-polarity/issues/140 support for dynamic locale
     const positiveToNegativeString = StringUtils.fillIn( moleculePolarityStrings.pattern.dipoleDirection, {
       from: moleculePolarityStrings.deltaPlus,
       to: moleculePolarityStrings.deltaMinus
     } );
 
     // d- -> d+
+    //TODO https://github.com/phetsims/molecule-polarity/issues/140 support for dynamic locale
     const negativeToPositiveString = StringUtils.fillIn( moleculePolarityStrings.pattern.dipoleDirection, {
       from: moleculePolarityStrings.deltaMinus,
       to: moleculePolarityStrings.deltaPlus

diff --git a/js/common/view/PartialChargeNode.js b/js/common/view/PartialChargeNode.js
@@ -57,6 +57,7 @@ class PartialChargeNode extends Node {
       if ( partialChargeVisible ) {
 
         // d+ or d-
+        //TODO https://github.com/phetsims/molecule-polarity/issues/140 support for dynamic locale
         textNode.text = ( partialCharge > 0 ) ? moleculePolarityStrings.deltaPlus : moleculePolarityStrings.deltaMinus;
 
         // size proportional to bond dipole magnitude

diff --git a/js/realmolecules/model/RealMolecule.js b/js/realmolecules/model/RealMolecule.js
@@ -16,6 +16,7 @@ import moleculePolarity from '../../moleculePolarity.js';
 
 class RealMolecule extends PhetioObject {
 
+  //TODO https://github.com/phetsims/molecule-polarity/issues/140 support for dynamic locale
   /**
    * @param {string} symbol - chemical symbol of the molecule
    * @param {string} fullName - full name of the molecule

diff --git a/js/realmolecules/view/RealMoleculeViewer.js b/js/realmolecules/view/RealMoleculeViewer.js
@@ -117,6 +117,8 @@ class RealMoleculeViewer extends Node {
 
     // unlink not needed
     moleculeProperty.link( molecule => {
+
+      //TODO https://github.com/phetsims/molecule-polarity/issues/140 support for dynamic locale
       moleculeText.text = StringUtils.fillIn( moleculePolarityStrings.pattern.symbolName, {
         symbol: molecule.symbol,
         name: molecule.fullName

diff --git a/js/realmolecules/view/RealMoleculesComboBox.js b/js/realmolecules/view/RealMoleculesComboBox.js
@@ -63,6 +63,7 @@ class RealMoleculesComboBox extends ComboBox {
 function createItem( molecule ) {
   assert && assert( molecule instanceof RealMolecule, 'invalid molecule' );
 
+  //TODO https://github.com/phetsims/molecule-polarity/issues/140 support for dynamic locale
   const text = StringUtils.fillIn( moleculePolarityStrings.pattern.symbolName, {
     symbol: molecule.symbol,
     name: molecule.fullName