-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How should the "Classical" to "Quantum" continuum bar behave when hiding radio buttons? #90
Comments
I suspect that this will require discussion at a design meeting, so labeling as such. |
Design Meeting January, 2nd Option 1 is ok!! |
We additionally decided to remove the panel that surrounds the radio buttons. |
@DianaTavares This is ready for review. I've hidden the outline of the panel that contains the continuum bar and radio buttons. Close if everything looks OK. |
Perfect! |
For PhET-iO, how should we handle the "Classical" to "Quantum" continuum bar (
continuumBarNode
) in the Spectra screen? The bar currently has a fixed length, so we end up with something like this if we hide a few of the radio buttons:I could certainly make the bar resize dynamically. But with anything less than 4 radio buttons, there is no room for the "Classical" and "Quantum" text (let alone translated versions that may be longer). So before proceeding, I'm going to toss this back to @DianaTavares and the design team.
Options:
continuumBarNode
will behave as shown above, always having a fixed height. If the space in the panel bothers the PhET-iO client, then they can setcontinuumBarNode.visibleProperty
to false and the panel will resize.continuumBarNode
dynamically resize and allow the text to overlap. When it overlaps, the PhET-iO client is responsible for settingcontinuumBarNode.visibleProperty
to false. This will look buggy, so I don't see the point in doing this.continuumBarNode
dynamically resize, and dynamically adjustmaxWidth
for the text. This will quickly result in unreadable text, so I don't see the point in doing this either.continuumBarNode
-- it's only visible if all 6 buttons are visible. This would preserve the continuum that PhET has intended.continuumBarNode
altogether, as we've done in the Energy Levels screen. I'm not sure how much this feature stimulates discussion about classical vs quantum models. But such discussion could be scaffolded in other ways.My recommendation is option 1, with a related note in examples.md.
The text was updated successfully, but these errors were encountered: