Skip to content

Commit

Permalink
hide border around ModelPanel, #90
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Jan 2, 2025
1 parent 07fceb9 commit b648634
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 17 deletions.
14 changes: 2 additions & 12 deletions js/common/MOTHAColors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,16 +118,6 @@ const MOTHAColors = {
projector: 'black'
} ),

modelsPanelFillProperty: new ProfileColorProperty( modelsOfTheHydrogenAtom, 'modelsPanelFill', {
default: 'black',
projector: 'white'
} ),

modelsPanelStrokeProperty: new ProfileColorProperty( modelsOfTheHydrogenAtom, 'modelsPanelStroke', {
default: Color.grayColor( 180 ),
projector: 'black'
} ),

modelsRadioButtonFillProperty: new ProfileColorProperty( modelsOfTheHydrogenAtom, 'modelsRadioButtonFill', {
default: 'black',
projector: 'white'
Expand All @@ -138,8 +128,8 @@ const MOTHAColors = {
} ),

modelsRadioButtonDeselectedStrokeProperty: new ProfileColorProperty( modelsOfTheHydrogenAtom, 'modelsRadioButtonDeselectedStroke', {
default: Color.grayColor( 100 ),
projector: Color.grayColor( 230 )
default: Color.grayColor( 120 ),
projector: Color.grayColor( 180 )
} ),

modelsRadioButtonOverStrokeProperty: new ProfileColorProperty( modelsOfTheHydrogenAtom, 'modelsRadioButtonOverStroke', {
Expand Down
9 changes: 4 additions & 5 deletions js/common/view/ModelPanel.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// Copyright 2015-2024, University of Colorado Boulder

/**
* ModelPanel contains controls (radio buttons) for choosing one of the predictive models.
* It is shown when the AB-switch is set to 'Model'.
* ModelPanel contains controls (radio buttons) for choosing one of the predictive models, and an optional
* 'Classical' to 'Continuum' bar. It is shown when the AB-switch is set to 'Model'.
*
* @author Chris Malley (PixelZoom, Inc.)
*/
Expand All @@ -16,7 +16,6 @@ import { HBox, Node } from '../../../../scenery/js/imports.js';
import Panel, { PanelOptions } from '../../../../sun/js/Panel.js';
import modelsOfTheHydrogenAtom from '../../modelsOfTheHydrogenAtom.js';
import HydrogenAtom from '../model/HydrogenAtom.js';
import MOTHAColors from '../MOTHAColors.js';
import MOTHAConstants from '../MOTHAConstants.js';
import ContinuumBarNode from './ContinuumBarNode.js';
import ModelRadioButtonGroup from './ModelRadioButtonGroup.js';
Expand All @@ -43,8 +42,8 @@ export default class ModelPanel extends Panel {
// PanelOptions
isDisposable: false,
visibleProperty: DerivedProperty.not( isExperimentProperty ),
fill: MOTHAColors.modelsPanelFillProperty,
stroke: MOTHAColors.modelsPanelStrokeProperty
fill: null,
stroke: null
}, providedOptions );

// radio buttons
Expand Down

0 comments on commit b648634

Please sign in to comment.