-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check the traversal order #76
Comments
A conversation needs to be had about suggested traversal order. Will put on docket for our next design meeting. |
We have not discussed this yet, but I think @marlitas and I can discuss it without needing the entire team. Our agenda is looking fairly packed this week. |
@Nancy-Salpepi pointed out in #90
|
@jessegreenberg and I worked on this last week and were able to get the traversal order and focus highlighting to work as discussed in a meeting with @amanda-phet. Sending back to @amanda-phet for feedback. |
Discussed 10/17/22 and we think the predict line should be in the tab order just after the valves and just before the "predict mean" checkbox. This way, the tab order for the prediction line is in a more logical place for predicting and then opening the valves. We also think it's a good user experience to check the box, then use shift+tab to go back and interact with the new element. |
This has been addressed and fixed in the above commits. Closing as completed. Feel free to re-open if there is more to discuss that I didn't catch! |
For code review #41 ...
In other sims that I've worked on, things in the "play area" are typically first in the traversal order. In this sim, the first thing is the "Predict Mean" checkbox, and I have to tab many times to get to the play area.
I'm not sure if this is how the traversal order was designed, or whether it hasn't been done yet. So including @amanda-phet in assignees.
The text was updated successfully, but these errors were encountered: