Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the traversal order #76

Closed
pixelzoom opened this issue Jun 28, 2022 · 7 comments
Closed

Check the traversal order #76

pixelzoom opened this issue Jun 28, 2022 · 7 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jun 28, 2022

For code review #41 ...

In other sims that I've worked on, things in the "play area" are typically first in the traversal order. In this sim, the first thing is the "Predict Mean" checkbox, and I have to tab many times to get to the play area.

I'm not sure if this is how the traversal order was designed, or whether it hasn't been done yet. So including @amanda-phet in assignees.

@pixelzoom pixelzoom changed the title Check the pdomOrder Check the traversal order Jun 28, 2022
@marlitas
Copy link
Contributor

A conversation needs to be had about suggested traversal order. Will put on docket for our next design meeting.

@marlitas marlitas removed their assignment Jun 29, 2022
@amanda-phet
Copy link
Contributor

We have not discussed this yet, but I think @marlitas and I can discuss it without needing the entire team. Our agenda is looking fairly packed this week.

@samreid
Copy link
Member

samreid commented Aug 24, 2022

@Nancy-Salpepi pointed out in #90

I also noticed that keyboard nav skips over the Valve toggle and Number or Cups. Let me know if you want me to make a new issue for that or if that is on your list already

@marlitas
Copy link
Contributor

@jessegreenberg and I worked on this last week and were able to get the traversal order and focus highlighting to work as discussed in a meeting with @amanda-phet. Sending back to @amanda-phet for feedback.

@amanda-phet
Copy link
Contributor

Discussed 10/17/22 and we think the predict line should be in the tab order just after the valves and just before the "predict mean" checkbox. This way, the tab order for the prediction line is in a more logical place for predicting and then opening the valves. We also think it's a good user experience to check the box, then use shift+tab to go back and interact with the new element.

@marlitas
Copy link
Contributor

This has been addressed and fixed in the above commits. Closing as completed. Feel free to re-open if there is more to discuss that I didn't catch!

@marlitas
Copy link
Contributor

Screen 1 Design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants