-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pdomOrder is specified incorrectly #47
Comments
I also see that IntroScreenView extends MeanShareAndBalanceScreenView. But MeanShareAndBalanceScreenView currently ignores So... You should probably investigate: (1) setting |
This issue is on hold until designer feedback for #76 is provided |
I believe I corrected pdomOrder specification in the commits in: #76 @pixelzoom can you review and provide feedback? |
Summary of Zoom discussion with @marlitas ... The end result looks correct, but a few things in the implementation... Delete this line in MeanShareAndBalanceScreenView.ts, it looks vestigial:
Make this change in IntroScreenView.ts: - this.screenViewRootNode.pdomOrder = [ waterCupLayerNode, controlPanel, predictMeanSlider ];
+ this.screenViewRootNode.pdomOrder = [ ...waterCup3DNodes, ...pipeNodes, controlPanel, predictMeanSlider, this.resetAllButton ]; ... so that you're not:
Feel free to close after changes. |
Fixed in above commit. Closing. Thanks @pixelzoom! |
For code review #41 ...
In https://github.com/phetsims/phet-info/blob/master/doc/alternative-input-quickstart-guide.md#traversal-order, 2 approaches are described for handling pdomOrder (aka traversal order).
IntroScreenView.ts currently appears to be leaning towards Approach 1, because it sets
this.pdomPlayAreaNode.pdomOrder
andthis.pdomControlAreaNode.pdomOrder
. But it does not follow the other requirement of Approach 1, which is to add children tothis.pdomPlayAreaNode
andthis.pdomControlAreaNode
, not directly to the ScreenView.Unless "play area" and "control area" have explicity been part of the sim design, it's recommended to follow Approach 2.
The text was updated successfully, but these errors were encountered: