Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implementation-note.md #260

Closed
marlitas opened this issue May 23, 2024 · 3 comments
Closed

implementation-note.md #260

marlitas opened this issue May 23, 2024 · 3 comments
Assignees
@marlitas
Labels
documentation Improvements or additions to documentation status:ready-for-review

Comments

@marlitas
Copy link
Contributor

Implementation-notes.md needs to be written and reviewed prior to code review.
@marlitas marlitas added the documentation Improvements or additions to documentation label May 23, 2024
@marlitas marlitas changed the title implementation-note.ms implementation-note.md May 29, 2024
@marlitas marlitas mentioned this issue May 29, 2024
Closed
81 tasks
marlitas added a commit that referenced this issue Jun 4, 2024
@marlitas
Update implementation-notes.md, see: #260
0e5cc74
marlitas added a commit that referenced this issue Jun 4, 2024
@marlitas
Complete implementation-notes.md, see: #260
2d22fe4
marlitas added a commit that referenced this issue Jun 4, 2024
@marlitas
Complete implementation-notes.md, see: #260
e76edf9
marlitas added a commit to phetsims/soccer-common that referenced this issue Jun 4, 2024
@marlitas
Complete implementation-notes.md, see: phetsims/mean-share-and-balanc…
8e4a100 
…e#260
@marlitas
Copy link
Contributor Author

marlitas commented Jun 4, 2024

I gave this an initial stab and I think it's ready for some additional eyes and editing. Over to @jbphet

@marlitas marlitas removed their assignment Jun 4, 2024
jbphet added a commit that referenced this issue Jun 5, 2024
@jbphet
reformat paragraphs for easier editing, quote screen titles, see #260
5997e4f
jbphet added a commit that referenced this issue Jun 5, 2024
@jbphet
reformat heading levels to better match model.md, see #260
87a7d67
jbphet added a commit that referenced this issue Jun 5, 2024
@jbphet
very minor edits, see #260
05ac8ca
@jbphet
Copy link
Contributor

jbphet commented Jun 5, 2024

Looks very good to me! Please review the very minor edits I made with my commits and the suggestions I have below.

Suggestions:

  • There is some inconsistency in the writing around whether to refer to "the mean" or "mean". I'm more accustomed to the former, but I don't know whether one is considered more correct. I poked around a bit online and it seemed to me that both are used but "the mean" is perhaps a bit more common.
  • I added some more about the use of the terms "table" and "notepad" in the code, please review and make sure we're good with this.

@jbphet jbphet assigned marlitas and unassigned jbphet Jun 5, 2024
@marlitas marlitas mentioned this issue Jun 7, 2024
Closed
81 tasks
marlitas added a commit that referenced this issue Jun 7, 2024
@marlitas
Use "the mean" instead of "mean", see: #260
6b8f6b2
@marlitas
Copy link
Contributor Author

marlitas commented Jun 7, 2024

I think the edits you made are good! I think this is in a good. I'll go ahead and close this as complete :-)

@marlitas marlitas closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marlitas marlitas

Labels
documentation Improvements or additions to documentation status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbphet @marlitas