Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Grab and Release sounds for the candy bars on Screen Two. #190

Closed
Ashton-Morris opened this issue Mar 26, 2024 · 9 comments
Closed
Assignees

Comments

@Ashton-Morris
Copy link
Contributor

I have these two files for this action that we reviewed in our meeting.

MSaBReleaseCandyBar.mp3
MSaBGrabCandyBar.mp3

And I also have a short demo of how it sounds.

MSaBGrabandReleaseCandyBarsVideoExample.mp4

I don't think this is the highest on the priority list given this comment in our document "EM: I’ll consult with Taliesin re her thoughts on this in case there are unique grab/drag considerations." but if you get around to it, I think we'd enjoy hearing it in context.

@marlitas
Copy link
Contributor

marlitas commented Apr 1, 2024

Accidentally committed to: #173. But this has been done for mouse interactions. I held back on keyboard since we are waiting on input from @terracoda as indicated above.

@jbphet
Copy link
Contributor

jbphet commented Apr 2, 2024

Reviewed in the 4/2/2024 sound design meeting, here are the notes:

  • It's a little bright, the team would like to try a version that has been run through a low-pass filter. @Ashton-Morris will create these and upload them.
  • Is the block sound a bit of a stretch? The idea is that these are wood block representations of the candy bars, but that seems a little challenging for people to understand, so should we just stick with the defaults?
  • We'd like @emily-phet to log her input on these sounds as well.

@amanda-phet
Copy link
Contributor

It's unclear to me what needs to be checked on with Taliesin, so @emily-phet can you let us know the status is of that?

@jbphet jbphet assigned Ashton-Morris and emily-phet and unassigned jbphet Apr 2, 2024
jbphet pushed a commit that referenced this issue Apr 3, 2024
@Ashton-Morris
Copy link
Contributor Author

Uploaded these filtered files to this folder.

  • MSaBReleaseCandyBarV2.mp3
  • MSaBGrabCandyBarV2.mp3

@Ashton-Morris Ashton-Morris assigned jbphet and unassigned Ashton-Morris Apr 9, 2024
jbphet added a commit that referenced this issue Apr 9, 2024
@jbphet
Copy link
Contributor

jbphet commented Apr 10, 2024

The updated sounds have been integrated, and sound pretty decent to me. I think we can review them at the next sound design meeting. Until then, I'll leave it assigned to @emily-phet since there is still an open question directed at her.

@jbphet jbphet removed their assignment Apr 10, 2024
@jbphet
Copy link
Contributor

jbphet commented Apr 16, 2024

We reviewed the latest in the 4/16/2024 sound design meetings, and we are good with these. Closing.

@jbphet jbphet closed this as completed Apr 16, 2024
@marlitas
Copy link
Contributor

marlitas commented Jun 6, 2024

While doing a self code review I found a TODO referencing this issue. Over to @jbphet.

// TODO: This only adds sound for mouse interactions. We will need to play the sound separately for keyboard.
    //  See: https://github.com/phetsims/mean-share-and-balance/issues/190

@marlitas marlitas reopened this Jun 6, 2024
@marlitas marlitas assigned jbphet and unassigned emily-phet Jun 6, 2024
jbphet added a commit that referenced this issue Jun 7, 2024
@jbphet
Copy link
Contributor

jbphet commented Jun 7, 2024

I removed the TODO and am investigating adding sound for grab and release via group sort interaction.

@jbphet
Copy link
Contributor

jbphet commented Jun 7, 2024

This is done and seems to be working well. Closing.

@jbphet jbphet closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants