-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Grab and Release sounds for the candy bars on Screen Two. #190
Comments
Accidentally committed to: #173. But this has been done for mouse interactions. I held back on keyboard since we are waiting on input from @terracoda as indicated above. |
Reviewed in the 4/2/2024 sound design meeting, here are the notes:
|
It's unclear to me what needs to be checked on with Taliesin, so @emily-phet can you let us know the status is of that? |
Uploaded these filtered files to this folder.
|
The updated sounds have been integrated, and sound pretty decent to me. I think we can review them at the next sound design meeting. Until then, I'll leave it assigned to @emily-phet since there is still an open question directed at her. |
We reviewed the latest in the 4/16/2024 sound design meetings, and we are good with these. Closing. |
While doing a self code review I found a TODO referencing this issue. Over to @jbphet.
|
I removed the TODO and am investigating adding sound for grab and release via group sort interaction. |
This is done and seems to be working well. Closing. |
I have these two files for this action that we reviewed in our meeting.
MSaBReleaseCandyBar.mp3
MSaBGrabCandyBar.mp3
And I also have a short demo of how it sounds.
MSaBGrabandReleaseCandyBarsVideoExample.mp4
I don't think this is the highest on the priority list given this comment in our document "EM: I’ll consult with Taliesin re her thoughts on this in case there are unique grab/drag considerations." but if you get around to it, I think we'd enjoy hearing it in context.
The text was updated successfully, but these errors were encountered: