Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grab/Release sounds for soccer balls #271

Closed
jbphet opened this issue Jun 7, 2024 · 3 comments
Closed

Grab/Release sounds for soccer balls #271

jbphet opened this issue Jun 7, 2024 · 3 comments
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Jun 7, 2024

While working on the grab and release sounds for the candy bars on the "Distribute" screen (see #190), I noticed that we do not have such sounds for grab and release of the soccer balls on the "Balance Point" screen. This seems a little inconsistent, so I thought I'd raise the question of whether we want to add sounds for this.

Note that the code for the soccer balls comes from the soccer-common repo, which is also heavily used in the Center and Variability sim, which also lacks sounds for grabbing and releasing the soccer balls. We should consider whether this behavior should also change if we add sounds for grabbing and releasing the soccer balls in Mean: Share and Balance.

@emily-phet
Copy link

My memory is that we specifically chose not to have grab and release sounds for the soccer balls, as they are intimately tied to the sound of their location. When you interact directly with the soccer balls, you should hear the sound (tone) associated with its new location, in lieu of a distinct grab/release sound. We thought that adding a release sound wasn't needed, as you already hear the tone representing the new location, and the grab sound seemed like it would clutter up the mapping we were aiming for.

@amanda-phet
Copy link
Contributor

I agree with @emily-phet that additional grab/release sounds aren't useful here. The number line tone is the useful thing. Since it's discrete, I also don't think grabbing and releasing are noticeable actions.. the noticeable thing is the location where the soccer ball is sitting.

@amanda-phet amanda-phet assigned jbphet and unassigned emily-phet and amanda-phet Jun 10, 2024
@jbphet
Copy link
Contributor Author

jbphet commented Jun 10, 2024

Sounds good, thanks for the explanations. Closing.

@jbphet jbphet closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants