Updated Ceiling_Y constant. #253

phetsims · Mar 13, 2018 · 34b65aa · 34b65aa
1 parent fa5dc1d
commit 34b65aa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/js/common/MassesAndSpringsConstants.js b/js/common/MassesAndSpringsConstants.js
@@ -30,7 +30,7 @@ define( function( require ) {
     FLOOR_Y: 0,
 
     // Y position of ceiling in meters. The ceiling is the top of the SpringHangerNode, just below the top of the dev view bounds
-    CEILING_Y: 1.48,
+    CEILING_Y: 1.47,
 
     // {Property.<Range>} range of damping associated with sim
     //RVEIEW: If exposing only Range, don't use a RangeWithValue? (or if used, document as such)

diff --git a/js/common/model/MassesAndSpringsModel.js b/js/common/model/MassesAndSpringsModel.js
@@ -197,10 +197,7 @@ define( function( require ) {
      */
     createSpring: function( x, tandem ) {
       var spring = new Spring(
-        //REVIEW: Is the 0.01 an important constant?
-        //REVIEW: Might be related to this comment in DisplacementArrowNode:
-        //REVIEW: TODO: We should find out why this -0.01 is outside the modelViewTransform. It can be negative but why is the number value there? @denz1994
-        new Vector2( x, MassesAndSpringsConstants.CEILING_Y - 0.01 ),
+        new Vector2( x, MassesAndSpringsConstants.CEILING_Y ),
         MassesAndSpringsConstants.DEFAULT_SPRING_LENGTH,
         this.dampingProperty.get(),
         tandem