Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GravityAccordionBox requires model #64

Closed
Denz1994 opened this issue Mar 1, 2019 · 3 comments
Closed

GravityAccordionBox requires model #64

Denz1994 opened this issue Mar 1, 2019 · 3 comments

Comments

@Denz1994
Copy link
Contributor

Denz1994 commented Mar 1, 2019

Comment here sums up initial thoughts.

This will add one more argument to the constructor.
@Denz1994 Denz1994 self-assigned this Mar 1, 2019
Denz1994 added a commit that referenced this issue Mar 1, 2019
@Denz1994
gravityAccordionBox refactored to use model.gravityProperty and model…
4d809f4 
….bodyProperty instead of the whole model. #64
@Denz1994
Copy link
Contributor Author

Denz1994 commented Mar 1, 2019

The commit above cleared things up. This should also be included in the RC branch.

Denz1994 added a commit that referenced this issue Mar 1, 2019
@Denz1994
gravityAccordionBox refactored to use model.gravityProperty and model…
1b9d627 
….bodyProperty instead of the whole model. #64
@Denz1994
Copy link
Contributor Author

Denz1994 commented Mar 1, 2019 •
edited
Loading

Fix cherry-picked into the RC branch. Awaiting verification that this isn't causing any sim breaking bugs.

This can be tested by adjusting the gravity slider and the body items in the combo box.

@Denz1994 Denz1994 removed their assignment Mar 1, 2019
Denz1994 added a commit that referenced this issue Mar 13, 2019
@Denz1994
Adjusted touchAreaDilation of thumbs for gravity slider and updated g…
3a56e7e 
…ravityAccordionBox signature. #60 #64

# Conflicts:
#	js/lab/view/GravityAccordionBox.js
@Denz1994 Denz1994 mentioned this issue Mar 13, 2019
Closed
8 tasks
@KatieWoe
Copy link
Contributor

This looks ok from what I've seen 1.0.0-rc.3. I hadn't seen this before, so I was a bit confused. But moving the gravity slider and choosing the different planets doesn't seem to cause any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Denz1994 @KatieWoe