Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pointer Area Overlap of mass adjuster #60

Closed
KatieWoe opened this issue Feb 12, 2019 · 6 comments
Closed

Pointer Area Overlap of mass adjuster #60

KatieWoe opened this issue Feb 12, 2019 · 6 comments
Assignees
@arouinfar @Denz1994
Labels
design:polish status:fixed-awaiting-deploy

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#281
This overlap of the mass adjustment slider and button can lead to the wrong object being selected, but it hasn't caused many problems unless I was trying.
71ac1050-83c3-42d9-b8d4-7cb4e9bd92a4
@KatieWoe KatieWoe added the type:bug Something isn't working label Feb 12, 2019
@arouinfar
Copy link
Contributor

@Denz1994 while you're adjusting the x-dilation on the mass slider thumb, you may also want to reduce the y-dilation on the gravity slider thumb so it doesn't overlap the combobox.

image

@arouinfar arouinfar added design:polish and removed type:bug Something isn't working labels Feb 12, 2019
Denz1994 added a commit that referenced this issue Feb 13, 2019
@Denz1994
Adjusted touchAreaDilation of thumbs for gravity and mass value slide…
813ff29 
…rs. #60
Denz1994 added a commit that referenced this issue Feb 13, 2019
@Denz1994
Adding updated dependencies for MAS. Commits handle touch area dilati…
abb948c 
…ons from #60
@Denz1994
Copy link
Contributor

touchAreaXDilation and touchAreaYDilation were adjusted for the gravity and mass value sliders. I will push another RC for verification/review.

@Denz1994
Copy link
Contributor

These changes should be cherry-picked into master at the next maintenance release of MAS

Denz1994 added a commit that referenced this issue Mar 13, 2019
@Denz1994
Adjusted touchAreaDilation of thumbs for gravity slider and updated g…
3a56e7e 
…ravityAccordionBox signature. #60 #64

# Conflicts:
#	js/lab/view/GravityAccordionBox.js
Denz1994 referenced this issue in phetsims/masses-and-springs Mar 13, 2019
@Denz1994
massValueControlPanel slider thumbTouchAreaXDilation reduced to preve…
be634e1 
…nt overlap.
Denz1994 added a commit to phetsims/masses-and-springs that referenced this issue Mar 13, 2019
@Denz1994
massValueControlPanel slider thumbTouchAreaXDilation reduced to preve…
6bdd54a 
…nt overlap. phetsims/masses-and-springs-basics#60
Denz1994 added a commit that referenced this issue Mar 13, 2019
@Denz1994
Updating dependencies for changes related to #60
a8321ef
@Denz1994
Copy link
Contributor

Changes cherry-picked into master. Also, some changes to the touchAreaXDialtion were committed to both relevant branches. This is ready for verification in next RC.

@Denz1994 Denz1994 mentioned this issue Mar 13, 2019
Closed
8 tasks
@KatieWoe
Copy link
Contributor Author

Still occurs a bit in both cases, but seems better. Will eave up to @arouinfar to see if she finds it acceptable. MASB 1.0.0-rc.3

@arouinfar
Copy link
Contributor

Comparnig rc.3 (left) to rc.2 (right), the pointer area overlaps have reduced, and look reasonable to me. I wouldn't want to make the x-dilation on the mass slider thumb any smaller because I think the slider would become harder to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

@Denz1994 Denz1994

Labels
design:polish status:fixed-awaiting-deploy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arouinfar @Denz1994 @KatieWoe