Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch: splash-script #391

Closed
samreid opened this issue Dec 17, 2016 · 6 comments
Closed

branch: splash-script #391

samreid opened this issue Dec 17, 2016 · 6 comments
Assignees
@samreid

Comments

@samreid
Copy link
Member

samreid commented Dec 17, 2016

See #382
@samreid
Copy link
Member Author

samreid commented Aug 15, 2017

Ready to merge to master. I messaged on dev public:

Sam Reid [1:23 PM]
Brace yourselves, I’m merging branches for chipper and joist to support splash screens.

[1:27]
I’ll also have to run grunt generate-development-html for each repo and commit it, so it will be a many-repo commit.

@samreid samreid self-assigned this Aug 15, 2017
@samreid samreid mentioned this issue Aug 15, 2017
Closed
@samreid
Copy link
Member Author

samreid commented Aug 15, 2017

I've locally merged and and run grunt generate-development-html. I tested 2 requirejs sims and one build at a few different screen sizes on mac chrome, all seems well. A bit of AQUA isn't revealing other problems. I noticed one potential phet-io problem I'll create a separate issue for.

@samreid samreid mentioned this issue Aug 15, 2017
Closed
samreid added a commit to phetsims/circuit-construction-kit-black-box-study that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
a8cdc5b 
…#391
samreid added a commit to phetsims/circuit-construction-kit-dc-virtual-lab that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
32d61e0 
…#391
samreid added a commit to phetsims/reactants-products-and-leftovers that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
3604e6a 
…#391
samreid added a commit to phetsims/balloons-and-static-electricity that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
563cb7f 
…#391
samreid added a commit to phetsims/balancing-chemical-equations that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
cafca18 
…#391
samreid added a commit to phetsims/circuit-construction-kit-dc that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
1365953 
…#391
samreid added a commit to phetsims/models-of-the-hydrogen-atom that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
9b14890 
…#391
samreid added a commit to phetsims/gene-expression-essentials that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
df2a6a4 
…#391
samreid added a commit to phetsims/area-model-multiplication that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
5d2824d 
…#391
samreid added a commit to phetsims/energy-skate-park-basics that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
53f44af 
…#391
samreid added a commit to phetsims/energy-forms-and-changes that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
19d3f2b 
…#391
samreid added a commit to phetsims/graphing-slope-intercept that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
07b4ecd 
…#391
samreid added a commit to phetsims/forces-and-motion-basics that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
2265171 
…#391
samreid added a commit to phetsims/gravity-force-lab-basics that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
f4c4c2c 
…#391
samreid added a commit to phetsims/isotopes-and-atomic-mass that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
cbb9fc9 
…#391
samreid added a commit to phetsims/least-squares-regression that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
c02fdeb 
…#391
samreid added a commit to phetsims/fluid-pressure-and-flow that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
4524e61 
…#391
samreid added a commit to phetsims/function-builder-basics that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
ea00684 
…#391
samreid added a commit to phetsims/states-of-matter-basics that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
91d6996 
…#391
samreid added a commit to phetsims/molecule-shapes-basics that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
2466409 
…#391
samreid added a commit to phetsims/proportion-playground that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
2622e88 
…#391
samreid added a commit to phetsims/rutherford-scattering that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
e58dd3b 
…#391
samreid added a commit to phetsims/capacitor-lab-basics that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
d841ad6 
…#391
samreid added a commit to phetsims/resistance-in-a-wire that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
5d4b053 
…#391
samreid added a commit to phetsims/atomic-interactions that referenced this issue Aug 15, 2017
@samreid
Generated development html with new splash screen, see phetsims/joist…
1e0dec0 
…#391
samreid added a commit to phetsims/simula-rasa that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
7b0fb18
samreid added a commit to phetsims/example-sim that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
8f46575
samreid added a commit to phetsims/arithmetic that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
861fe21
samreid added a commit to phetsims/unit-rates that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
322f526
samreid added a commit to phetsims/estimation that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
0dbae88
samreid added a commit to phetsims/make-a-ten that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
0e3c50c
samreid added a commit to phetsims/hookes-law that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
3550bd5
samreid added a commit to phetsims/optics-lab that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
e3fb92e
samreid added a commit to phetsims/trig-tour that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
30d35c8
samreid added a commit to phetsims/ph-scale that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
75feecf
samreid added a commit to phetsims/molarity that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
89cedd2
samreid added a commit to phetsims/friction that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
a114a7a
samreid added a commit to phetsims/seasons that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
e78983e
samreid added a commit to phetsims/griddle that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
cf4dd04
@samreid
Copy link
Member Author

samreid commented Aug 18, 2017

Branch merged and ready for deletion (here and in chipper). I'll verify, delete, close.

samreid added a commit to phetsims/neuron that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
284c8b9
samreid added a commit to phetsims/chains that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
1c569c9
samreid added a commit to phetsims/twixt that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
6f27c1f
samreid added a commit to phetsims/vegas that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
08dff53
samreid added a commit to phetsims/blast that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
7ae961b
samreid added a commit that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see #391
cc9b9d6
samreid added a commit to phetsims/vibe that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
abc1fd5
samreid added a commit to phetsims/sun that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
50f640e
@samreid
Copy link
Member Author

samreid commented Aug 18, 2017

Branch deleted, closing.

@samreid samreid closed this as completed Aug 18, 2017
samreid added a commit to phetsims/ohms-law that referenced this issue Aug 18, 2017
@samreid
Removed stale comments, see phetsims/joist#391
a549dfe
@zepumph
Copy link
Member

zepumph commented Apr 20, 2021

Should be re-deleted as part of phetsims/special-ops#198

@zepumph zepumph reopened this Apr 20, 2021
@samreid
Copy link
Member Author

samreid commented Apr 23, 2021

Deleted via the GitHub web interface, closing.

@samreid samreid closed this as completed Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph