-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev Test: New Splash Screen #36
Comments
A reminder to test phetsims/joist#408 phetsims/joist#407 when this gets to the QA team. |
@samreid all looks good to me |
Thanks @ariel-phet. A reminder to the QA team during testing to test out phetsims/joist#408 phetsims/joist#407 in particular. |
@samreid anything to add before @phet-steele takes over |
It's all set, let me know how it goes. |
@samreid looks good on our supported platforms. All linked issues have been taken care of as well. |
Thanks @phet-steele, I'll merge this to master and it will be ready for new deploys from master. |
I'll proceed in phetsims/joist#391, many thanks @phet-steele |
From phetsims/joist#408 phetsims/joist#407 and phetsims/joist#349 we have made the following changes to the splash screen:
I published an Energy Skate Park: Basics version here that has these changes. It will need to be tested on all of our supported platforms because it uses new preload code + css that may have platform-specific issues.
http://www.colorado.edu/physics/phet/dev/html/energy-skate-park-basics/1.3.1-dev.6/energy-skate-park-basics_en.html
Before setting the entire QA team loose on this, it would be best if @ariel-phet could review the current implementation for design issues (sizing and how the pulse-download animation looks). If all is well, then we can expand the testing. If your internet connection is too fast, you may have trouble seeing the download part of the animation. You can use Chrome Dev Tools to throttle your download speed. View => Developer => Developer Tools=> Network => "No throttling" (in the top right) can be changed as desired.
The text was updated successfully, but these errors were encountered: