Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Test: New Splash Screen #36

Closed
samreid opened this issue Aug 12, 2017 · 8 comments
Closed

Dev Test: New Splash Screen #36

samreid opened this issue Aug 12, 2017 · 8 comments
Assignees
Labels
QA:dev-test Dev test before an RC

Comments

@samreid
Copy link
Member

samreid commented Aug 12, 2017

From phetsims/joist#408 phetsims/joist#407 and phetsims/joist#349 we have made the following changes to the splash screen:

  1. It should be sized proportionally to the screen size
  2. It should show a pulsing animation while downloading

I published an Energy Skate Park: Basics version here that has these changes. It will need to be tested on all of our supported platforms because it uses new preload code + css that may have platform-specific issues.
http://www.colorado.edu/physics/phet/dev/html/energy-skate-park-basics/1.3.1-dev.6/energy-skate-park-basics_en.html

Before setting the entire QA team loose on this, it would be best if @ariel-phet could review the current implementation for design issues (sizing and how the pulse-download animation looks). If all is well, then we can expand the testing. If your internet connection is too fast, you may have trouble seeing the download part of the animation. You can use Chrome Dev Tools to throttle your download speed. View => Developer => Developer Tools=> Network => "No throttling" (in the top right) can be changed as desired.
image

@samreid
Copy link
Member Author

samreid commented Aug 12, 2017

A reminder to test phetsims/joist#408 phetsims/joist#407 when this gets to the QA team.

@ariel-phet
Copy link
Contributor

@samreid all looks good to me

@samreid
Copy link
Member Author

samreid commented Aug 14, 2017

Thanks @ariel-phet. A reminder to the QA team during testing to test out phetsims/joist#408 phetsims/joist#407 in particular.

@ariel-phet
Copy link
Contributor

@samreid anything to add before @phet-steele takes over

@samreid
Copy link
Member Author

samreid commented Aug 14, 2017

It's all set, let me know how it goes.

@samreid samreid removed their assignment Aug 14, 2017
@phet-steele
Copy link
Contributor

@samreid looks good on our supported platforms. All linked issues have been taken care of as well.

@samreid
Copy link
Member Author

samreid commented Aug 15, 2017

Thanks @phet-steele, I'll merge this to master and it will be ready for new deploys from master.

@samreid
Copy link
Member Author

samreid commented Aug 15, 2017

I'll proceed in phetsims/joist#391, many thanks @phet-steele

@samreid samreid closed this as completed Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:dev-test Dev test before an RC
Projects
None yet
Development

No branches or pull requests

3 participants