Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SettingsDialog should extend Dialog #289

Closed
pixelzoom opened this issue Aug 19, 2015 · 3 comments
Closed

SettingsDialog should extend Dialog #289

pixelzoom opened this issue Aug 19, 2015 · 3 comments
Assignees
@pixelzoom

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Aug 19, 2015 •
edited
Loading

Factored out of #166.

SettingsDialog currently extends ScreenView. It should extend Dialog.
@pixelzoom
Copy link
Contributor Author

This dialog is not currently used. And if/when it extends Dialog, I don't see much of the current implementation that will survive. Recommended to delete SettingsDialog and its usage in PhetMenu.

@samreid Your opinion?

samreid added a commit that referenced this issue Dec 8, 2016
@samreid
Removed SettingsDialog, see #289
629bc9f
samreid added a commit that referenced this issue Dec 8, 2016
@samreid
Removed unused require statements, see #289
0742e7f
samreid added a commit that referenced this issue Dec 8, 2016
@samreid
Removed unused string key, see #289
a268786
@samreid
Copy link
Member

samreid commented Dec 8, 2016

I removed the SettingsDialog in the preceding commits. As far as I know, we do not need to remove stale keys from babel. @pixelzoom would you like to review the changes?

@samreid samreid assigned pixelzoom and unassigned samreid Dec 8, 2016
@pixelzoom
Copy link
Contributor Author

👍 Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @pixelzoom