Skip to content

Commit

Permalink
Removed SettingsDialog, see #289
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Dec 8, 2016
1 parent 2374ffa commit 629bc9f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 101 deletions.
27 changes: 5 additions & 22 deletions js/PhetMenu.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ define( function( require ) {
var inherit = require( 'PHET_CORE/inherit' );
var AboutDialog = require( 'JOIST/AboutDialog' );
var OptionsDialog = require( 'JOIST/OptionsDialog' );
var SettingsDialog = require( 'JOIST/SettingsDialog' );
var UpdateDialog = require( 'JOIST/UpdateDialog' );
var Rectangle = require( 'SCENERY/nodes/Rectangle' );
var ButtonListener = require( 'SCENERY/input/ButtonListener' );
Expand Down Expand Up @@ -241,11 +240,11 @@ define( function( require ) {
present: !!sim.options.optionsNode,
callback: function() {

if ( !optionsDialog ) {
optionsDialog = new OptionsDialog( sim.options.optionsNode, {
tandem: tandem.createTandem( 'optionsDialog' )
} );
}
if ( !optionsDialog ) {
optionsDialog = new OptionsDialog( sim.options.optionsNode, {
tandem: tandem.createTandem( 'optionsDialog' )
} );
}

optionsDialog.show();
},
Expand Down Expand Up @@ -287,22 +286,6 @@ define( function( require ) {
sim.mailEventLog();
}
},
{
text: menuItemSettingsString,
present: false,
callback: function() {
var settingsDialog = new SettingsDialog( sim.showPointersProperty );

// TODO: This is broken. Should probably use new Dialog infrastruture
var plane = new Plane( { fill: 'black', opacity: 0.3 } );
sim.addChild( plane );
sim.addChild( settingsDialog );
settingsDialog.addDoneListener( function() {
plane.detach();
settingsDialog.detach();
} );
}
},
{
text: menuItemReportAProblemString,
present: isPhETBrand && !isPhetApp,
Expand Down
79 changes: 0 additions & 79 deletions js/SettingsDialog.js

This file was deleted.

0 comments on commit 629bc9f

Please sign in to comment.