Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HomeScreen entries in LookAndFeel? #255

Closed
pixelzoom opened this issue Jun 25, 2015 · 3 comments
Closed

HomeScreen entries in LookAndFeel? #255

pixelzoom opened this issue Jun 25, 2015 · 3 comments

Comments

@pixelzoom
Copy link
Contributor

HomeScreen currently seems to assume that the background will always be 'black'. Perhaps that's an OK assumption. But if that ever changes, we'll need entries for the home screen in LookAndField.
@pixelzoom pixelzoom mentioned this issue Jun 25, 2015
Closed
pixelzoom added a commit that referenced this issue Jun 30, 2015
@pixelzoom
#255 pull out fill properties related to home screen, add TODO item a…
b4e8a54 
…bout moving them to LookAndFeel
pixelzoom added a commit that referenced this issue Jun 30, 2015
@pixelzoom
#255 set home screen background color in HomeScreen, not in HomeScree…
a483910 
…nView, and use it correctly in Sim to update LookAndFeel.backgroundColor
@pixelzoom pixelzoom changed the title HomeScreen entries in LookAndField? HomeScreen entries in LookAndFeel? Jul 3, 2015
@pixelzoom pixelzoom mentioned this issue Nov 29, 2016
Open
@pixelzoom
Copy link
Contributor Author

Folding this issue into #222. Closing.

@samreid
Copy link
Member

samreid commented May 21, 2020

There are still TODOs marked for this issue, discovered during phetsims/chipper#946

@samreid samreid reopened this May 21, 2020
samreid added a commit that referenced this issue Feb 15, 2021
@samreid
Update TODO reference, see #255 and #222
1e60801
@samreid
Copy link
Member

samreid commented Feb 15, 2021

I pointed the TODO at #222, closing.

@samreid samreid closed this as completed Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @pixelzoom