Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"adapted from" text doesn't show up in the home screen #239

Closed
jbphet opened this issue May 21, 2015 · 3 comments
Closed

"adapted from" text doesn't show up in the home screen #239

jbphet opened this issue May 21, 2015 · 3 comments
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented May 21, 2015

I'm using the adapted-from-phet brand repo, and the "adapted from" text is not showing up in the home screen of a multi-screen simulation. I've tested on States of Matter and Build and Atom, and this is true for both. The text does show up when on the individual screens.

I tried setting the color of the text to always be red in AdaptedFromPhETText.js, and the text was visible on both the home screen and the individual sim screens, so the problem is tied to the state of navigationBarTextFillProperty.

@pixelzoom
Copy link
Contributor

The problem is that the "adapted from" texted is fill with sim.lookAndFeel.navigationBarTextFillProperty, which defaults to 'black' and doesn't have a correct value until a screen is selected and a navbar is created.

The home screen doesn't currently have and properties in the lookAndFeel (perhaps it should, see #255) and assumes a 'black' background. So I'm going to literally set the "adapted from" fill to 'white' for the home screen.

@pixelzoom
Copy link
Contributor

Fixed. Assigned to @samreid to verify.

@samreid
Copy link
Member

samreid commented Jun 25, 2015

Code diffs look good, I also checked out the adapted-from-phet branch of the brand repo, and tested in Acid Base Solutions and Gravity and Orbits, and it looked great, nice work, closing.

@samreid samreid closed this as completed Jun 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants