Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description for the Layer Model screen #374

Closed
jbphet opened this issue Nov 22, 2023 · 7 comments
Closed

Add description for the Layer Model screen #374

jbphet opened this issue Nov 22, 2023 · 7 comments
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Nov 22, 2023

Description for the Photons screen is nearing completion, and the spec is ready for the developers to start implementation of description in the Layer Model screen.

See spec at https://docs.google.com/document/d/1lkpnGpLhbvjRphW5bITHLGyKsj-OGq4WWO98ZM2wKVM/edit?usp=sharing for the details of how this should behave.

jbphet added a commit that referenced this issue Nov 27, 2023
@jessegreenberg jessegreenberg self-assigned this Nov 27, 2023
@jbphet jbphet self-assigned this Nov 28, 2023
jbphet added a commit to phetsims/phetcommon that referenced this issue Nov 28, 2023
jbphet added a commit that referenced this issue Nov 29, 2023
@jbphet
Copy link
Contributor Author

jbphet commented Dec 16, 2023

@arouinfar - @jessegreenberg and I have worked through the spec and believe we have covered most everything. I'm assigning this issue to you to start the review. There is one known issue, listed in #375, about the surface and the layers reporting that they've reached equilibrium several times in rapid succession. Please ignore that problem for now, and we will work on it in parallel with your review.

I've published a dev version for you to use for the review so that you're not working with a moving target. Please see https://phet-dev.colorado.edu/html/greenhouse-effect/1.3.0-dev.2/phet/.

@jbphet
Copy link
Contributor Author

jbphet commented Dec 29, 2023

Unassigning myself since I've now resolved the problems related to equilibrium. I'll address issues resulting from the review of the Layer Model screen description as they arise.

@arouinfar
Copy link
Contributor

Layer Model review is complete. I identified a few issues, all tagged above, so closing this issue.

@phet-dev phet-dev reopened this Jan 11, 2024
@phet-dev
Copy link
Contributor

Reopening because there is a TODO marked for this issue.

@arouinfar
Copy link
Contributor

@jbphet this issue was automatically reopened due to a TODO, so back to you.

@jbphet
Copy link
Contributor Author

jbphet commented Jan 18, 2024

The TODO said, in part, "Next add the context response for the value change", and it was referring to the sunlight intensity. That was definitely added when the alerter for the Layer Model was created, so it is now safe to simply remove this TODO. Done, re-closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants