Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider restructuring a11y strings #373

Closed
jessegreenberg opened this issue Nov 20, 2023 · 2 comments
Closed

Consider restructuring a11y strings #373

jessegreenberg opened this issue Nov 20, 2023 · 2 comments
Assignees

Comments

@jessegreenberg
Copy link
Contributor

Consider moving some of the nested "waves" strings out. Particularly from the "screenSummary" key. They are now shared by the "photons" screen and so the nesting doesn't reflect the usage which is confusing. This doesn't impact functionality but would improve maintainability, so consider this if there is time.

@jbphet
Copy link
Contributor

jbphet commented Nov 28, 2023

For the record, I did some restructuring of these strings while working on #374 to move shared strings out from under the "waves" key to the general "a11y" key.

@jbphet
Copy link
Contributor

jbphet commented Jan 17, 2024

I've moved the string keys that are now command and were subkeys of a11y.waves.screenSummary to be under the more general a11y key. I did a bit more generalization as well, and I think I'm ready to close this issue. We don't really have any standards for how to structure the a11y strings, and it seems like the structure isn't used much anyway - we mostly just search through the file. So...closing.

@jbphet jbphet closed this as completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants