You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Consider moving some of the nested "waves" strings out. Particularly from the "screenSummary" key. They are now shared by the "photons" screen and so the nesting doesn't reflect the usage which is confusing. This doesn't impact functionality but would improve maintainability, so consider this if there is time.
The text was updated successfully, but these errors were encountered:
For the record, I did some restructuring of these strings while working on #374 to move shared strings out from under the "waves" key to the general "a11y" key.
I've moved the string keys that are now command and were subkeys of a11y.waves.screenSummary to be under the more general a11y key. I did a bit more generalization as well, and I think I'm ready to close this issue. We don't really have any standards for how to structure the a11y strings, and it seems like the structure isn't used much anyway - we mostly just search through the file. So...closing.
Consider moving some of the nested "waves" strings out. Particularly from the "screenSummary" key. They are now shared by the "photons" screen and so the nesting doesn't reflect the usage which is confusing. This doesn't impact functionality but would improve maintainability, so consider this if there is time.
The text was updated successfully, but these errors were encountered: