Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Width of wave coming from atmosphere layer can be greater that what is going in #236

Closed
jbphet opened this issue Dec 21, 2022 · 2 comments
Closed

Comments

@jbphet
Copy link
Contributor

jbphet commented Dec 21, 2022

While doing some testing prior to prototype publication (see #220), I noticed that it's pretty easy to create a situation where the intensity of the wave that is coming out of an atmosphere layer is greater than the intensity of the wave that is intersecting with that layer. While there could be some situations where this would make sense, like when the atmosphere previously had a lot of energy and is now cooling off, that's not what was going on when I was seeing this.

Here is a screenshot. One wave is coming from the ground at the lower left and another is coming from that atmosphere where the first one intersects with a layer. The width of the emitted wave at its origin is significantly bigger than the width of the incoming wave.

image

I suspect this is somehow related to the work done for wave intensity propagation in #84.

@jbphet jbphet self-assigned this Dec 21, 2022
@jbphet
Copy link
Contributor Author

jbphet commented Dec 22, 2022

A fix for this is now implemented on master. I feel like the new behavior is significantly better, because it's much easier to see how more greenhouse gases in the atmosphere "shave off" more of the IR as it moves through the atmosphere.

@arouinfar - Can you take a look and make sure you're good with this change? High priority on this, since I'm hoping to publish a prototype RC tomorrow.

@arouinfar
Copy link
Contributor

@jbphet looks good in master.

The worst I can do is this, but it occurs very briefly after a large spike in greenhouse gas concentration. I don't think I would have noticed unless I was looking for it.
image

jbphet added a commit that referenced this issue Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants