Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperature readout of highest layer can get occluded by energy balance indicator #230

Closed
jbphet opened this issue Dec 8, 2022 · 2 comments
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Dec 8, 2022

This problem is probably best told in pictures.

image

image

This was pointed out during today's design meeting. We decided that the best fix would be to move the indicator to the right when the energy balance indicator is active. @arouinfar said that this should not block the publication of the prototype for #220.

@jbphet
Copy link
Contributor Author

jbphet commented Dec 12, 2022

I've implemented a change that makes the temperature display move out of the way when the energy balance indicator is visible. @arouinfar - Please review and close if this looks good to you, or comment and assign back to me if not.

@jbphet jbphet assigned arouinfar and unassigned jbphet Dec 12, 2022
@jbphet
Copy link
Contributor Author

jbphet commented Dec 14, 2022

The design team, including @arouinfar , reviewed this in today's meeting and this has been approved. Closing.

@jbphet jbphet closed this as completed Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants