Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ResetAllButton.isResettingAllProperty to mute sound in MassSoundGenerator #328

Closed
jbphet opened this issue Apr 12, 2024 · 3 comments
Closed

Use ResetAllButton.isResettingAllProperty to mute sound in MassSoundGenerator #328

jbphet opened this issue Apr 12, 2024 · 3 comments
Assignees
@zepumph
Labels
status:ready-for-review

Comments

@jbphet
Copy link
Contributor

jbphet commented Apr 12, 2024

In phetsims/tambo#190 a more globally available flag was created that can be used to determine if a "reset all" action is in progress. This could be used in MassSoundGenerator to mute sound generation during reset.
@jbphet jbphet self-assigned this Apr 12, 2024
jbphet added a commit to phetsims/gravity-force-lab that referenced this issue Apr 12, 2024
@jbphet
use ResetAllButton.isResettingAllProperty to mute sound during resets…
9d5fc5e 
…, see phetsims/gravity-force-lab-basics#328
@jbphet
Copy link
Contributor Author

jbphet commented Apr 12, 2024

Changes made. Assigning to @zepumph for review, as he is listed as the responsible dev for this sim.

@jbphet jbphet assigned zepumph and unassigned jbphet Apr 12, 2024
jbphet added a commit to phetsims/gravity-force-lab that referenced this issue Apr 12, 2024
@jbphet
use ResetAllButton.isResettingAllProperty to mute sound during resets…
7e9214d 
…, see phetsims/gravity-force-lab-basics#328
@jbphet
Copy link
Contributor Author

jbphet commented Apr 12, 2024

Note that this also affects gravity-force-lab, but it doesn't seem like it's worth a separate issue. Both should be reviewed.

jbphet added a commit that referenced this issue Apr 12, 2024
@jbphet
use ResetAllButton.isResettingAllProperty to mute sound during resets…
7da2777 
…, see #328
@zepumph
Copy link
Member

zepumph commented Apr 13, 2024

Looks great, thanks

@zepumph zepumph closed this as completed Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbphet @zepumph