Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distance: Toggle quantitatve/qualitative distance description infront of helptext with toggle of Distance checkbox (title changed)) #101

Closed
terracoda opened this issue Feb 20, 2019 · 4 comments

Comments

@terracoda
Copy link

terracoda commented Feb 20, 2019

In addition to #100, please update the first sentence of the Sphere Position help text paragraph. The first sentence is a dynamic distance description of distance and I'd like it to include the word "centers" toggle with the Distance check box.

This first sentence needs to toggle between quantitative (distance checked) and qualitative (distance not checked) descriptions for distance. This is working in the descriptions of the Mass Spheres, and it also needs to happen here.

When Distance is checked use the quantitative distance in kilometers:

  • Centers of spheres, {{{{4}} kilometers apart}}}}. Move spheres closer or farther from each other.

When Distance is NOT checked use the qualitative described distance (same as in state-of-the-sim list):

  • Centers of spheres, {{{{close to}} each other}}}}. Move spheres closer or farther from each other.
@terracoda terracoda changed the title Remove quantitatve distance description infront of helptext when Distance is not checked. Distance: Remove quantitatve distance description infront of helptext when Distance is not checked. Feb 21, 2019
@terracoda terracoda changed the title Distance: Remove quantitatve distance description infront of helptext when Distance is not checked. Distance: Toggle quantitatve/qualitative distance description infront of helptext with toggle of Distance checkbox (title changed)) Feb 25, 2019
@terracoda
Copy link
Author

@zepumph, I updating the previous comment and the issue title to be match the screenshots shown in issue #100.

@terracoda
Copy link
Author

Screen shot showing this change is in #100.

@zepumph
Copy link
Member

zepumph commented Feb 27, 2019

Implemented above. I updated the code so the REGULAR and BASICS were using the same PDOM Node for the ul that help the sphere position sliders in the PDOM.

I then updated the BASICS help text to toggle qualitative/quantitative descriptions depending on if distance values are showing.

There was also a bit more refactoring to reuse a string piece that looks like {{close to}} each other within the PositionDescriber class. Over to you @terracoda to review.

zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Feb 27, 2019
@zepumph zepumph assigned terracoda and unassigned zepumph Feb 27, 2019
zepumph added a commit to phetsims/gravity-force-lab that referenced this issue Feb 27, 2019
@terracoda
Copy link
Author

Awesome. Distance in help text looks good in both views. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants