-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distance: Add quantitative distanace to dynamic-state-of-sim & update the phrase with qualitative distance when distance is not checked. #100
Comments
@zepumph, I just noticed in the A11y View that the prepositions, "to" and "from" are missing in that second bullet that provides the qualitative distance descriptions. Would it stream-line things if we just put the propositions in as part of the region name? |
@zepumph, there are 3 issues all related to the dynamic distance phrases in the PDOM of BASICS:
I'm including a screen of A11y View as to where these issues point to. When Distance is checked, the PDOM should look like this: When Distance is NOT checked, the PDOM should look like this (@terracoda to add corrected visual): |
@zepumph, the titles of each of the related issues has "Distance" at the front. |
@zepumph, with the slightly changed phrasing I think I can leave "from each other" off the comparative descriptions in the intro and the help text. That might it all much more stream-lined. |
In #88 (comment), @zepumph shared two sets of distance strings:
Assuming they are literal representations of the strings, I think we need the full strings (RELATIVE_DISTANCE_STRINGS), the ones including the preposition "to" or "from" when describing the qualitative distance in the actual PDOM. That is to say, in the scene summary, in the mass sphere descriptions and in the sentence before the help text. All these instances need a preposition. |
Awesome. Distance in help text looks good in both views. Closing. |
Oops verified incorrect change. |
Awesome. The the second bullet in the state of the sim describing distance between centers looks good in both views. Closing. |
I just noticed that we are missing the quantitative distance information from the dynamic state-of-the-sim list. See bolded text at the end of the second bullet:
The second bullet is dynamic should always have qualitative distance and when Distance is checked it should also include quantitative distance in kilometers. Please use the following phrases depending on whether or not Distance is checked:
When Distance is checked:
And when Distance is not checked, please we update the phrase by adding "Centers of" at the beginning. I think this will be good to reinforce concept that distance is measured from center to center even when distance is unchecked.
The text was updated successfully, but these errors were encountered: