Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distance: Add quantitative distanace to dynamic-state-of-sim & update the phrase with qualitative distance when distance is not checked. #100

Closed
terracoda opened this issue Feb 20, 2019 · 11 comments

Comments

@terracoda
Copy link

I just noticed that we are missing the quantitative distance information from the dynamic state-of-the-sim list. See bolded text at the end of the second bullet:

Currently, force on mass 1 by mass 2 is equal in size and opposite in direction of force on mass 2 by mass 1.

  • Force arrows are {{tiny}} {{at 33.4 newtons}}.
  • Mass 1 and mass 2 are {{not so close to}} each other {{, centers exactly {{4 kilometers}} apart}}.
  • If Distance not checked: Centers of mass 1 and mass 2 are {{not so close to}} each other.
  • Mass of mass 1 is {{2}} billion kilograms, {{much much smaller than}} mass 2 at {{4}} billion kilograms}}.
  • Robots {{pull very little}} keeping spheres in place.

The second bullet is dynamic should always have qualitative distance and when Distance is checked it should also include quantitative distance in kilometers. Please use the following phrases depending on whether or not Distance is checked:

When Distance is checked:

  • Mass 1 and mass 2 are {{not so close to}} each other {{, centers exactly {{4 kilometers}} apart}}.

And when Distance is not checked, please we update the phrase by adding "Centers of" at the beginning. I think this will be good to reinforce concept that distance is measured from center to center even when distance is unchecked.

  • Centers of mass 1 and mass 2 are {{not so close to}} each other.
@terracoda
Copy link
Author

@zepumph, I just noticed in the A11y View that the prepositions, "to" and "from" are missing in that second bullet that provides the qualitative distance descriptions.

Would it stream-line things if we just put the propositions in as part of the region name?

@terracoda terracoda changed the title Add quantitative distanace to dynamic-state-of-sim & update the phrase with qualitative distance when distance is not checked. Distance: Add quantitative distanace to dynamic-state-of-sim & update the phrase with qualitative distance when distance is not checked. Feb 21, 2019
@terracoda
Copy link
Author

terracoda commented Feb 21, 2019

@zepumph, there are 3 issues all related to the dynamic distance phrases in the PDOM of BASICS:

I'm including a screen of A11y View as to where these issues point to.

When Distance is checked, the PDOM should look like this:
pdom-distance-checked

When Distance is NOT checked, the PDOM should look like this (@terracoda to add corrected visual):
pdom-distance-notchecked

@terracoda
Copy link
Author

@zepumph, the titles of each of the related issues has "Distance" at the front.

@terracoda
Copy link
Author

@zepumph, with the slightly changed phrasing I think I can leave "from each other" off the comparative descriptions in the intro and the help text. That might it all much more stream-lined.

@terracoda
Copy link
Author

@zepumph, please note that once the new ranges for described qualitative distance are implemented in #88, the described distance for a distance of 4 kilometers will be "close to" rather than "not so close to".

@terracoda
Copy link
Author

The screen shots in this issue (#100) link together three issues: this one (#100), #94, and #101.

@terracoda
Copy link
Author

terracoda commented Feb 26, 2019

In #88 (comment), @zepumph shared two sets of distance strings:

  • RELATIVE_DISTANCE_STRINGS
  • DISTANCE_STRINGS

Assuming they are literal representations of the strings, I think we need the full strings (RELATIVE_DISTANCE_STRINGS), the ones including the preposition "to" or "from" when describing the qualitative distance in the actual PDOM. That is to say, in the scene summary, in the mass sphere descriptions and in the sentence before the help text. All these instances need a preposition.

zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Feb 26, 2019
zepumph added a commit to phetsims/gravity-force-lab that referenced this issue Feb 26, 2019
@zepumph
Copy link
Member

zepumph commented Feb 26, 2019

In the above commits I fixed the distance/position related screen summary bullet, I.E.
image

@terracoda
Copy link
Author

Awesome. Distance in help text looks good in both views. Closing.

@terracoda terracoda reopened this Mar 5, 2019
@terracoda
Copy link
Author

Oops verified incorrect change.

@terracoda
Copy link
Author

Awesome. The the second bullet in the state of the sim describing distance between centers looks good in both views. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants