-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scene buttons may not line up with scene reset buttons #348
Comments
This seems good to work on for the next dev version. |
The quick fix would be to disable relayout of that section. That would take 5 minutes and probably be good enough for a dev version. The better long-term fix would be to reimplement that code around the idea of putting the reset button as part of the radio button components. That was desired for the original design, but we decided against it in order to speed up turnaround time for a dev version. Therefore, I recommend to commit the quick fix to unblock a dev version. But we should try again to reimplement that code for better long term behavior for a later dev version or RC. |
…igned with the reset buttons, see #348
After the commit, the radio button no longer relayout based on their visibility: Let's call that sufficient for this issue and I'll open a new issue about the long term fix prescribed in the preceding comment. @KatieWoe can you please confirm on master? If it works OK, please reassign to @arouinfar to make sure this is acceptable for a dev version. |
Looks fixed on master |
@arouinfar is this acceptable for a dev version? |
@samreid I agree with this 100%. The quick fix is great for the dev version. |
Thanks, closing. We will continue in #350 |
For phetsims/qa#505. Mostly scene in studio, but discovered in multi wrapper.
When you make one of the scene buttons invisible, the others readjust to take its place. However, the reset buttons for those scenes do not move when this happens, meaning the reset buttons are no longer properly lined up the the scene they control.
The text was updated successfully, but these errors were encountered: