Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nest the reset buttons with the scene radio buttons #350

Closed
samreid opened this issue Jun 17, 2020 · 2 comments
Closed

Nest the reset buttons with the scene radio buttons #350

samreid opened this issue Jun 17, 2020 · 2 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Jun 17, 2020

From #348:

The better long-term fix would be to reimplement that code around the idea of putting the reset button as part of the radio button components (instead of parallel). That was desired for the original design, but we decided against it in order to speed up turnaround time for a dev version.

I searched for another issue about this, but couldn't find one.

@samreid
Copy link
Member Author

samreid commented Aug 16, 2020

I'd like to double check with @arouinfar before working on this. Currently the scene reset buttons are under the sceneControl like so:

image

This issue is about moving them to be children of their corresponding radio buttons, like the planetMoonSceneResetButton would move under sceneControl.sceneSelectionRadioButtonGroup.planetMoonSceneRadioButton. But that could be confusing, since it isn't coded as a child of the planetMoonSceneRadioButton and making the planetMoonSceneRadioButton invisible will not make the planetMoonSceneResetButton invisible. So I thought I should double check about what is desired here before spending time on it.

@samreid samreid assigned arouinfar and unassigned samreid Aug 16, 2020
@arouinfar
Copy link
Contributor

Thanks for checking in @samreid. I think it would be confusing to make the SceneResetButton a child of the corresponding SceneRadioButton. Let's leave the tree structure as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants