You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The better long-term fix would be to reimplement that code around the idea of putting the reset button as part of the radio button components (instead of parallel). That was desired for the original design, but we decided against it in order to speed up turnaround time for a dev version.
I searched for another issue about this, but couldn't find one.
The text was updated successfully, but these errors were encountered:
I'd like to double check with @arouinfar before working on this. Currently the scene reset buttons are under the sceneControl like so:
This issue is about moving them to be children of their corresponding radio buttons, like the planetMoonSceneResetButton would move under sceneControl.sceneSelectionRadioButtonGroup.planetMoonSceneRadioButton. But that could be confusing, since it isn't coded as a child of the planetMoonSceneRadioButton and making the planetMoonSceneRadioButton invisible will not make the planetMoonSceneResetButton invisible. So I thought I should double check about what is desired here before spending time on it.
Thanks for checking in @samreid. I think it would be confusing to make the SceneResetButton a child of the corresponding SceneRadioButton. Let's leave the tree structure as-is.
From #348:
I searched for another issue about this, but couldn't find one.
The text was updated successfully, but these errors were encountered: