-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrument PatternStringProperty and DerivedProperty for strings that need to be autoselectable in Studio. #186
Comments
There are no PatternStringProperty in this sim, so just DerivedProperty. |
This is on-hold, pending resolution of 2 issues:
|
For this sim, I'm going to take a different approach than phetsims/fourier-making-waves#235. I'm not going to instrument the RichText markup that is added to math symbols (the Properties in GQSymbols.ts). Those cases add the most "nesting" to dependencies, and seemed to be the least useful in Fourier. I've noted this a code comment via the commit above. The result of this decision: strings that appear in the UI and contain symbols are not autoselectable in Studio. The set of symbols is: a, b, c, h, k, p, x, x2, y @arouinfar please review in Studio and let me know how this feels. |
Thanks @pixelzoom. As expected, there is quite a bit of text that is not autoselectable, but it all pertains to equations and related coefficients. The experience does not seem buggy, and I think it's easier to direct users to things like |
#178 resulted in a bunch of new DerivedProperty instances that dynamically create strings that appear in the UI. Per https://github.com/phetsims/phet-io/issues/1942, they will need to be instrumented for PhET-iO. And per phetsims/fourier-making-waves#235, we need to decided where they live in the Studio tree.
The text was updated successfully, but these errors were encountered: