Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dynamic locale #178

Closed
pixelzoom opened this issue Aug 30, 2022 · 4 comments
Closed

Add support for dynamic locale #178

pixelzoom opened this issue Aug 30, 2022 · 4 comments
Assignees
@arouinfar
Labels
dev:phet-io status:blocks-sim-publication status:ready-for-review

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Aug 30, 2022 •
edited
Loading

... similar to what was done in phetsims/natural-selection#319.

@kathy-phet said:

And this isn't a current priority, so let's visit that one after you have these others converted

Note that since graphing-lines is a dependency of this sim, this will also involve touching graphing-lines.
@pixelzoom pixelzoom self-assigned this Aug 30, 2022
This was referenced Aug 30, 2022
Closed
Closed
@pixelzoom pixelzoom changed the title Add support to dynamic locale Add support for dynamic locale Aug 30, 2022
@pixelzoom
Copy link
Contributor Author

Unassigning until this becomes a priority.

@pixelzoom pixelzoom removed their assignment Sep 13, 2022
@pixelzoom pixelzoom self-assigned this Jun 1, 2023
pixelzoom added a commit that referenced this issue Jun 6, 2023
@pixelzoom
support for dynamic locale, #178
b24468d
pixelzoom added a commit to phetsims/graphing-lines that referenced this issue Jun 6, 2023
@pixelzoom
support for dynamic locale, phetsims/graphing-quadratics#178
8e3c0ec
pixelzoom added a commit to phetsims/graphing-lines that referenced this issue Jun 6, 2023
@pixelzoom
support for dynamic locale, phetsims/graphing-quadratics#178
3979a6e
pixelzoom added a commit to phetsims/graphing-lines that referenced this issue Jun 6, 2023
@pixelzoom
support for dynamic locale, phetsims/graphing-quadratics#178
62f5cc3
pixelzoom added a commit to phetsims/graphing-lines that referenced this issue Jun 6, 2023
@pixelzoom
support for dynamic locale, phetsims/graphing-quadratics#178
ffad157
pixelzoom added a commit that referenced this issue Jun 6, 2023
@pixelzoom
add xAxisLabelString and yAxisLabelString parameters to GraphNode, be…
e7d3d57 
…cause it's used in 2 sims with different string Properties, #178
pixelzoom added a commit to phetsims/graphing-lines that referenced this issue Jun 6, 2023
@pixelzoom
add xAxisLabelString and yAxisLabelString parameters to GraphNode, be…
0aad176 
…cause it's used in 2 sims with different string Properties, phetsims/graphing-quadratics#178
pixelzoom added a commit that referenced this issue Jun 7, 2023
@pixelzoom
change GQSymbols to string Properties, #178
01b22d8
pixelzoom added a commit to phetsims/graphing-lines that referenced this issue Jun 7, 2023
@pixelzoom
change GQSymbols to string Properties, phetsims/graphing-quadratics#178
1a00839
pixelzoom added a commit that referenced this issue Jun 7, 2023
@pixelzoom
https://github.com/phetsims/graphing-quadratics/issues/178
7b8913a
pixelzoom added a commit that referenced this issue Jun 7, 2023
@pixelzoom
https://github.com/phetsims/graphing-quadratics/issues/178
3035ce5
pixelzoom added a commit that referenced this issue Jun 8, 2023
@pixelzoom
https://github.com/phetsims/graphing-quadratics/issues/178
da9414a
pixelzoom added a commit that referenced this issue Jun 8, 2023
@pixelzoom
https://github.com/phetsims/graphing-quadratics/issues/178
1777c64
pixelzoom added a commit to phetsims/graphing-lines that referenced this issue Jun 8, 2023
@pixelzoom
https://github.com/phetsims/graphing-quadratics/issues/178
f43b2a9
pixelzoom added a commit that referenced this issue Jun 8, 2023
@pixelzoom
https://github.com/phetsims/graphing-quadratics/issues/178
967acd6
pixelzoom added a commit that referenced this issue Jun 8, 2023
@pixelzoom
supportsDynamicLocale: true, grunt modulify, #178
6c64a0b
pixelzoom added a commit that referenced this issue Jun 8, 2023
@pixelzoom
https://github.com/phetsims/graphing-quadratics/issues/178
38f7909
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jun 8, 2023 •
edited
Loading

This is done. Supporting dynamic strings is a lot of work when those strings appear in equations, and it required major layout changes in this sims.

These changes did not require additional migration rules, which I find a bit surprising.

Ready for review when this sim gets scheduled for re-publishing.

@pixelzoom pixelzoom removed their assignment Jun 8, 2023
@pixelzoom pixelzoom mentioned this issue Jun 8, 2023
Closed
@pixelzoom pixelzoom mentioned this issue Jun 8, 2023
Closed
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jun 9, 2023 •
edited
Loading

Getting this sim ready for dev testing is a task for June 9-29 iteration, so relabeling and assigning this issue accordingly.

@arouinfar
Copy link

@pixelzoom I reviewed Graphing Quadratics on master with stringTest=dynamic and the layout reflows really nicely. I didn't notice any issues with maxWidth or layout changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

Labels
dev:phet-io status:blocks-sim-publication status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @arouinfar