set visibleProperty for PointOnParabolaManipulator, #148

phetsims · Mar 5, 2021 · abd9328 · abd9328
1 parent 3e4c969
commit abd9328
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 13 deletions.
diff --git a/js/focusanddirectrix/view/FocusAndDirectrixGraphNode.js b/js/focusanddirectrix/view/FocusAndDirectrixGraphNode.js
@@ -66,8 +66,8 @@ class FocusAndDirectrixGraphNode extends GQGraphNode {
       model.quadraticProperty,
       model.graph,
       model.modelViewTransform,
-      viewProperties.pointOnParabolaVisibleProperty,
       viewProperties.coordinatesVisibleProperty, {
+        visibleProperty: viewProperties.pointOnParabolaVisibleProperty,
         tandem: tandem.createTandem( 'pointOnParabolaManipulator' ),
         phetioDocumentation: 'the manipulator for changing the point on the parabola'
       } );

diff --git a/js/focusanddirectrix/view/PointOnParabolaManipulator.js b/js/focusanddirectrix/view/PointOnParabolaManipulator.js
@@ -25,12 +25,10 @@ class PointOnParabolaManipulator extends GQManipulator {
    * @param {Property.<Quadratic>} quadraticProperty - the interactive quadratic
    * @param {Graph} graph
    * @param {ModelViewTransform2} modelViewTransform
-   * @param {BooleanProperty} pointOnParabolaVisibleProperty
    * @param {BooleanProperty} coordinatesVisibleProperty
    * @param {Object} [options]
    */
-  constructor( pointOnParabolaProperty, quadraticProperty, graph, modelViewTransform,
-               pointOnParabolaVisibleProperty, coordinatesVisibleProperty, options ) {
+  constructor( pointOnParabolaProperty, quadraticProperty, graph, modelViewTransform, coordinatesVisibleProperty, options ) {
 
     options = merge( {
 
@@ -85,12 +83,6 @@ class PointOnParabolaManipulator extends GQManipulator {
     pointOnParabolaProperty.link( pointOnParabola => {
       this.translation = modelViewTransform.modelToViewPosition( pointOnParabola );
     } );
-
-    // visibility of this Node
-    pointOnParabolaVisibleProperty.link( visible => {
-      this.interruptSubtreeInput(); // cancel any drag that is in progress
-      this.visible = visible;
-    } );
   }
 }
 

diff --git a/js/graphing-quadratics-phet-io-overrides.js b/js/graphing-quadratics-phet-io-overrides.js
@@ -128,9 +128,6 @@ window.phet.preloads.phetio.phetioElementsOverrides =
     "graphingQuadratics.focusAndDirectrixScreen.view.leftPointToolNode.visibleProperty": {
       "phetioFeatured": true
     },
-    "graphingQuadratics.focusAndDirectrixScreen.view.pointOnParabolaManipulator.visibleProperty": {
-      "phetioReadOnly": true
-    },
     "graphingQuadratics.focusAndDirectrixScreen.view.rightPointToolNode.visibleProperty": {
       "phetioFeatured": true
     },