move phetioReadOnly:false from overrides.js to code for vertexManipul…

…ator.visibleProperty and focusManipulator.visibleProperty, #148
phetsims · Mar 5, 2021 · 3e4c969 · 3e4c969
1 parent 55f294c
commit 3e4c969
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 11 deletions.
diff --git a/js/common/view/VertexManipulator.js b/js/common/view/VertexManipulator.js
@@ -47,7 +47,8 @@ class VertexManipulator extends GQManipulator {
       coordinatesDecimals: GQConstants.VERTEX_DECIMALS,
 
       // phet-io
-      phetioDocumentation: 'a manipulator for the vertex'
+      phetioDocumentation: 'a manipulator for the vertex',
+      phetioReadOnly: true // because visibility is derived below
 
     }, options );
 

diff --git a/js/focusanddirectrix/view/FocusManipulator.js b/js/focusanddirectrix/view/FocusManipulator.js
@@ -47,7 +47,8 @@ class FocusManipulator extends GQManipulator {
       coordinatesDecimals: GQConstants.FOCUS_DECIMALS,
 
       // phet-io
-      phetioDocumentation: 'manipulator for the focus'
+      phetioDocumentation: 'manipulator for the focus',
+      phetioReadOnly: true // because visibility is derived below
 
     }, options );
 

diff --git a/js/graphing-quadratics-phet-io-overrides.js b/js/graphing-quadratics-phet-io-overrides.js
@@ -122,9 +122,6 @@ window.phet.preloads.phetio.phetioElementsOverrides =
     "graphingQuadratics.focusAndDirectrixScreen.view.equationAccordionBox.interactiveEquationNode.visibleProperty": {
       "phetioFeatured": true
     },
-    "graphingQuadratics.focusAndDirectrixScreen.view.focusManipulator.visibleProperty": {
-      "phetioReadOnly": true
-    },
     "graphingQuadratics.focusAndDirectrixScreen.view.graphControlPanel.visibleProperty": {
       "phetioFeatured": true
     },
@@ -137,9 +134,6 @@ window.phet.preloads.phetio.phetioElementsOverrides =
     "graphingQuadratics.focusAndDirectrixScreen.view.rightPointToolNode.visibleProperty": {
       "phetioFeatured": true
     },
-    "graphingQuadratics.focusAndDirectrixScreen.view.vertexManipulator.visibleProperty": {
-      "phetioReadOnly": true
-    },
     "graphingQuadratics.focusAndDirectrixScreen.view.viewProperties.coordinatesVisibleProperty": {
       "phetioFeatured": true
     },
@@ -297,9 +291,6 @@ window.phet.preloads.phetio.phetioElementsOverrides =
     "graphingQuadratics.vertexFormScreen.view.rightPointToolNode.visibleProperty": {
       "phetioFeatured": true
     },
-    "graphingQuadratics.vertexFormScreen.view.vertexManipulator.visibleProperty": {
-      "phetioReadOnly": true
-    },
     "graphingQuadratics.vertexFormScreen.view.viewProperties.axisOfSymmetryVisibleProperty": {
       "phetioFeatured": true
     },