Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise screenshots for 1.3.0 release #99

Closed
4 tasks done
pixelzoom opened this issue Nov 2, 2018 · 9 comments
Closed
4 tasks done

revise screenshots for 1.3.0 release #99

pixelzoom opened this issue Nov 2, 2018 · 9 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Nov 2, 2018

The changes in #91 and #94 have changed how this sim looks, so screenshots will need to be revised, including:

  • graphing-lines-screenshot.png
  • graphing-lines-screenshot-alt1.png
  • graphing-lines-screenshot-alt2.png
  • graphing-lines-screenshot-alt3.png

This needs to be done before 1.3.0 publication.

@pixelzoom pixelzoom changed the title revise screenshots revise screenshots for 1.3.0 release Nov 7, 2018
@amanda-phet
Copy link
Contributor

@KatieWoe Can you re-create the GL screenshots using the latest dev version? There were some visual changes to the sim, but the sim configurations do not need to change. Feel free to paste them here for me to verify if you would like.

@KatieWoe
Copy link
Contributor

KatieWoe commented Nov 8, 2018

@amanda-phet
graphing-lines-screenshot
graphing-lines-screenshot-alt1
graphing-lines-screenshot-alt2
graphing-lines-screenshot-alt3

@amanda-phet
Copy link
Contributor

The slope screen is just missing the saved line at y=-2.

For point-slope, let's do a different equation that makes it easier to see the equation on the line. How about y-3 = -8/12 (x - -5)
image

Thanks!

@KatieWoe
Copy link
Contributor

KatieWoe commented Nov 8, 2018

@amanda-phet
graphing-lines-screenshot-alt1
graphing-lines-screenshot-alt2

@amanda-phet
Copy link
Contributor

Point-slope looks good.

Can you just make sure the Slope screen has y=-2, not y=2? The horizontal line should go through that purple point.

@KatieWoe
Copy link
Contributor

@amanda-phet
graphing-lines-screenshot-alt1

@amanda-phet
Copy link
Contributor

You got it- thanks!

KatieWoe added a commit that referenced this issue Nov 16, 2018
@KatieWoe KatieWoe assigned pixelzoom and unassigned KatieWoe Nov 16, 2018
@KatieWoe
Copy link
Contributor

Above commit should do it. @amanda-phet @pixelzoom look over and close if acceptable.

@pixelzoom
Copy link
Contributor Author

I verified that the screenshots in GitHub match what @amanda-phet approved in the above comments, and that images sizes are the new standard 1536x1008.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants