-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use standard font for math symbols #94
Comments
Yes, we should definitely update the font to be in sync with the newest math sims. |
Notes on how to do this...
Symbols appear in:
|
This needs to be addressed (at least partially) for Graphing Quadratics, see phetsims/graphing-quadratics#93. |
…tics#93 Signed-off-by: Chris Malley <[email protected]>
Signed-off-by: Chris Malley <[email protected]>
Signed-off-by: Chris Malley <[email protected]>
Signed-off-by: Chris Malley <[email protected]>
Signed-off-by: Chris Malley <[email protected]>
Signed-off-by: Chris Malley <[email protected]>
Signed-off-by: Chris Malley <[email protected]>
@amanda-phet please review 1.3.0-dev.2. While Graphing Quadratics uses 'normal' font weight for equations, Graphing Lines uses 'bold'. I don't know if that's something we need to change, but it's trivial to do so. Let me know if you'd like to see a dev version of Graphing Lines with 'normal' weight. |
Looks great to me! Let's keep bold. I didn't look through all game challenges, but a quick review of everything looked really nice to me. |
Thanks. Marking as "fixed awaiting deploy". |
@amanda-phet @pixelzoom are we OK with the math text being bold? GQ screenshot used by @pixelzoom in #94 (comment) |
This issue deals with the font (not the font weight, e.g. 'bold') used for math symbols. Font and weight are specified separately. The font weight remains the same as it was in the published version of Graphing Lines and Graphing Slope-Intercept. That said... Graphing Lines and Graphing Slope-Intercept use |
When we made the decision to use the math font in this sim, we all agreed the appearance looked good (even if we didn't explicitly discuss the weight). I am happy keeping it bold, and I think it works well in this sim next to all of those pickers. |
Back to you @lmulhall-phet. |
We'll close this issue after testing on a few more platforms. |
@lmulhall-phet @KatieWoe Since phetsims/qa#277 and phetsims/qa#278 have been completed, can this issue be closed? |
Yes |
Graphing Lines does not use the font that PhET has standardized on for math symbols (italic Times New Roman). Should we update it to do so? For example, x, y, m, a, b, c in:
Graphing Lines:
Graphing Quadratics:
The text was updated successfully, but these errors were encountered: