Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use standard font for math symbols #94

Closed
pixelzoom opened this issue Sep 24, 2018 · 13 comments
Closed

use standard font for math symbols #94

pixelzoom opened this issue Sep 24, 2018 · 13 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Sep 24, 2018

Graphing Lines does not use the font that PhET has standardized on for math symbols (italic Times New Roman). Should we update it to do so? For example, x, y, m, a, b, c in:

Graphing Lines:

screenshot_762

Graphing Quadratics:

screenshot_763

@amanda-phet
Copy link
Contributor

Yes, we should definitely update the font to be in sync with the newest math sims.

@pixelzoom pixelzoom changed the title use standard font for math symbols? use standard font for math symbols Oct 27, 2018
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Oct 28, 2018

Notes on how to do this...

  • See GQSymbols for a good approach to creating symbols that contain the appropriate markup for RichText.

  • Verify that MathSymbols is used throughout for equals, plus, minus, etc.

  • Switch a bunch of things from Text to RichText.

Symbols appear in:

  • checkbox labels
  • equation titles on AccordionBoxes
  • interactive equations
  • equations on lines
  • axis labels on the graph
  • axis labels on icons
  • Game challenges

@pixelzoom
Copy link
Contributor Author

This needs to be addressed (at least partially) for Graphing Quadratics, see phetsims/graphing-quadratics#93.

@pixelzoom pixelzoom self-assigned this Oct 28, 2018
pixelzoom added a commit that referenced this issue Oct 28, 2018
pixelzoom added a commit that referenced this issue Oct 28, 2018
pixelzoom added a commit that referenced this issue Oct 28, 2018
pixelzoom added a commit that referenced this issue Oct 28, 2018
Signed-off-by: Chris Malley <[email protected]>
pixelzoom added a commit that referenced this issue Oct 28, 2018
pixelzoom added a commit that referenced this issue Oct 28, 2018
@pixelzoom
Copy link
Contributor Author

@amanda-phet please review 1.3.0-dev.2.

While Graphing Quadratics uses 'normal' font weight for equations, Graphing Lines uses 'bold'. I don't know if that's something we need to change, but it's trivial to do so. Let me know if you'd like to see a dev version of Graphing Lines with 'normal' weight.

@amanda-phet
Copy link
Contributor

Looks great to me! Let's keep bold.

I didn't look through all game challenges, but a quick review of everything looked really nice to me.

@pixelzoom
Copy link
Contributor Author

Thanks. Marking as "fixed awaiting deploy".

@ghost
Copy link

ghost commented Feb 4, 2019

@amanda-phet @pixelzoom are we OK with the math text being bold?

GSI 1.1.0-rc.1
screen shot 2019-02-04 at 11 37 09 am
screen shot 2019-02-04 at 11 37 16 am

GQ screenshot used by @pixelzoom in #94 (comment)
gq

@ghost ghost assigned amanda-phet and pixelzoom Feb 4, 2019
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Feb 4, 2019

This issue deals with the font (not the font weight, e.g. 'bold') used for math symbols. Font and weight are specified separately. The font weight remains the same as it was in the published version of Graphing Lines and Graphing Slope-Intercept.

That said... Graphing Lines and Graphing Slope-Intercept use weight: 'bold' a lot, while Graphing Quadratics uses bold much more judiciously (and to my eye, has a cleaner look). If that's something we want to change, it would be a new issue. And I don't feel like it's something that should be changed this late in the game for this RC, but that's @amanda-phet's call.

@amanda-phet
Copy link
Contributor

When we made the decision to use the math font in this sim, we all agreed the appearance looked good (even if we didn't explicitly discuss the weight). I am happy keeping it bold, and I think it works well in this sim next to all of those pickers.

@amanda-phet amanda-phet reopened this Feb 4, 2019
@pixelzoom pixelzoom assigned ghost and unassigned pixelzoom and amanda-phet Feb 4, 2019
@pixelzoom
Copy link
Contributor Author

Back to you @lmulhall-phet.

@ghost
Copy link

ghost commented Feb 4, 2019

We'll close this issue after testing on a few more platforms.

@ghost ghost removed their assignment Feb 4, 2019
@pixelzoom
Copy link
Contributor Author

@lmulhall-phet @KatieWoe Since phetsims/qa#277 and phetsims/qa#278 have been completed, can this issue be closed?

@pixelzoom pixelzoom assigned ghost and KatieWoe Feb 11, 2019
@KatieWoe
Copy link
Contributor

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants