Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance sign-off #98

Closed
pixelzoom opened this issue May 29, 2019 · 2 comments
Closed

performance sign-off #98

pixelzoom opened this issue May 29, 2019 · 2 comments

Comments

@pixelzoom
Copy link
Contributor

This is an item from the Master Checklist, to be completed by the Lead Designer.

@pixelzoom
Copy link
Contributor Author

@arouinfar This is ready for your review. You can use master or 1.0.0-dev.36.

The worst-case scenario is shown below: the Energy screen with 2000 particles, all accordion boxes expanded, all 4 "species histogram" checkboxes checked (histograms are updated only when visible), and the stopwatch running.

Please identify any platforms where we might need to squeeze out more performance.

screenshot_1238

@arouinfar
Copy link
Contributor

@pixelzoom performance is looking pretty smooth, even in the worst-case scenario described in #98 (comment).

According to @KatieWoe we no longer support iOS 9 or iOS 10, so I tested dev.36 on these devices:

  • Chadwick, Chromebook running latest Chrome (74.0.3729.159)
  • Pauling, iPad Air 2, iOS 11.3
  • Leibniz, iPair Air 2, iOS 12

The iPads had a pretty low frame rate (~15 FPS) in the worst-case scenario, but the particle animation still looked reasonable and UI elements all remained responsive with no noticeable lag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants