-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wallSpeedLimit looks incorrect #115
Comments
I'll investigate. dev.32 and dev.36 should both have // Speed limit for the container's left movable wall, in pm/ps. Relevant when reducing the container size.
// For internal use only.
wallSpeedLimit: {
type: 'number',
isValidValue: value => ( value > 0 ),
defaultValue: 800
} |
I reproduced the problem - dev.36 and master are indeed faster than dev.32. dev.35 looks correct, so something changed between dev.35 (6/5/19 @ 7:18pm) and dev.36. (6/5/19 @ 9:35pm). There's only one relevant changeset between dev.35 and dev.36: a7c7a54 |
Fixed in the above commit. There were some ofter changes, and it looks like perhaps the container was getting stepped twice, sorry about that. @arouinfar please verify in master or 1.0.0-dev.37. |
Looking good in dev.37, thanks @pixelzoom! |
In reviewing the performance for #98, I noticed that the wallSpeedLimit for compression looks incorrect in dev.36. It appears quite a bit faster than dev.32 which had the appropriate speed limit. Not sure if the compression speed limit was correct when I reviewed #90 (comment) in master, but I believe it was.
The text was updated successfully, but these errors were encountered: