Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhET-iO instrumentation #77

Closed
pixelzoom opened this issue May 16, 2019 · 3 comments
Closed

PhET-iO instrumentation #77

pixelzoom opened this issue May 16, 2019 · 3 comments
Assignees
@pixelzoom
Labels
dev:phet-io

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented May 16, 2019 •
edited
Loading

I have attempted to consider PhET-iO while architecting & implementing this sim. But with the exception of top-level model and view classes, the 1.0 release of this simulation will not be instrumented for PhET-iO.

This issue is where I'll capture miscellaneous notes that will be useful for future instrumentation. It might be useful to have the design team review these notes before publishing 1.0.
@pixelzoom pixelzoom mentioned this issue May 17, 2019
Closed
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jun 11, 2019 •
edited
Loading

I experimented with using ObservableArray to store Particles, more details in In #116. The thought was that this would be a quick way to save/restore state of the particle system, get access to particles, etc. The performance was significantly compromised, so beware about going down that path when this sim is instrumented.

@pixelzoom
Copy link
Contributor Author

Since the 1.0 branch was created, there have been extensive PhET0-iO changes that were not patched into the 1.0 branch. When it's time to do a brand=phet-io release, plan on doing it in a new branch, with master shas, and a complete QA process.

@jbphet jbphet mentioned this issue Dec 2, 2019
Closed
pixelzoom added a commit that referenced this issue Mar 18, 2021
@pixelzoom
pass visibleProperty to Nodes where possible, #77
746da8c
@pixelzoom pixelzoom mentioned this issue Mar 4, 2024
Closed
pixelzoom added a commit that referenced this issue Mar 19, 2024
@pixelzoom
TODO #77
db4ba08
pixelzoom added a commit that referenced this issue Mar 19, 2024
@pixelzoom
TODO #77
c08e0f8
@pixelzoom pixelzoom changed the title PhET-iO instrumentation notes PhET-iO instrumentation Mar 19, 2024
@pixelzoom pixelzoom self-assigned this Apr 3, 2024
pixelzoom added a commit that referenced this issue Apr 30, 2024
@pixelzoom
BicyclePumpNode instrumentation, #77
88d2988
pixelzoom added a commit to phetsims/scenery-phet that referenced this issue Apr 30, 2024
@pixelzoom
BicyclePumpNode instrumentation, phetsims/gas-properties#77
3fed00a
pixelzoom added a commit that referenced this issue Apr 30, 2024
@pixelzoom
add histogramModel.speed and histogramModel.kineticEnergy, #77
1774df7
pixelzoom added a commit that referenced this issue Apr 30, 2024
@pixelzoom
add link to collisionCounter, #77
a1f16f4
pixelzoom added a commit that referenced this issue Apr 30, 2024
@pixelzoom
add linked elements, #77
3757411
@pixelzoom pixelzoom mentioned this issue Apr 30, 2024
Closed
pixelzoom added a commit that referenced this issue May 1, 2024
@pixelzoom
instrument container.isOpenProperty, #77
391a281
pixelzoom added a commit that referenced this issue May 1, 2024
@pixelzoom
instrument model.modelBoundsProperty, #77
89dc499
pixelzoom added a commit that referenced this issue May 1, 2024
@pixelzoom
replace model.timeTransform with model.getTimeTransform(), #77
661b968
pixelzoom added a commit that referenced this issue May 1, 2024
@pixelzoom
instrument collisionCounter.timeRunningProperty, #77
3887ed7
pixelzoom added a commit that referenced this issue May 1, 2024
@pixelzoom
instrument container.desiredWidthProperty and previousLeftProperty, #77
7ee41a7
pixelzoom added a commit that referenced this issue May 1, 2024
@pixelzoom
instrument container.userIsAdjustingWidthProperty, no need to instrum…
b66764f 
…ent leftWallVelocity, #77
pixelzoom added a commit that referenced this issue May 1, 2024
@pixelzoom
conditionally instrument things that are not relevant when container …
16a15da 
…has a fixed width, #77
pixelzoom added a commit that referenced this issue May 1, 2024
@pixelzoom
delete unnecessary widthProperty listener, #77
ba7eaab
pixelzoom added a commit that referenced this issue May 1, 2024
@pixelzoom
rename hasDividerProperty to isDividedProperty, #77
d9717d0
pixelzoom added a commit that referenced this issue May 8, 2024
@pixelzoom
delete TODO, #77
2e6c958
pixelzoom added a commit that referenced this issue May 8, 2024
@pixelzoom
add TODOs, #77
1d11003
pixelzoom added a commit that referenced this issue May 9, 2024
@pixelzoom
Revert "delete TODO, #77"
f5bba6d 
This reverts commit 1601098.
pixelzoom added a commit that referenced this issue May 9, 2024
@pixelzoom
Revert "assign particles to collision-detection regions after PhET-iO…
8162d53 
… state has been restored, #77"

This reverts commit f64d8db.
pixelzoom added a commit that referenced this issue May 9, 2024
@pixelzoom
revise instrumentation for CollisionDetector and Region, rename Colli…
4c602cd 
…sionDetector.update to step, #77
pixelzoom added a commit that referenced this issue May 9, 2024
@pixelzoom
simplify constructor for IdealGasLawParticleSystemNode, simply update…
8d22b15 
…s when sim is paused, #77
pixelzoom added a commit that referenced this issue May 9, 2024
@pixelzoom
HistogramsModelIO for serializing samples, #77
b6bfd35
pixelzoom added a commit that referenced this issue May 9, 2024
@pixelzoom
clean up applyState method, #77
3db396d
pixelzoom added a commit that referenced this issue May 9, 2024
@pixelzoom
HistogramsModelIO for serializing samples, #77
f54392f
pixelzoom added a commit that referenced this issue May 9, 2024
@pixelzoom
add TODOs, #77
3ef3808
pixelzoom added a commit that referenced this issue May 9, 2024
@pixelzoom
ParticleFlowRateModelIO for serializing samples, #77
c191140
pixelzoom added a commit that referenced this issue May 9, 2024
@pixelzoom
revert conversion of dtAccumulator to Property, #77
6701d90
pixelzoom added a commit that referenced this issue May 9, 2024
@pixelzoom
AverageSpeedModelIO for instrumenting running average, #77
7274656
pixelzoom added a commit that referenced this issue May 9, 2024
@pixelzoom
TODOs, #77
1c4bc46
pixelzoom added a commit that referenced this issue May 9, 2024
@pixelzoom
use spread instead of forEach for unpacking samples from stateObject, #…
411b610 
…77
pixelzoom added a commit that referenced this issue May 9, 2024
@pixelzoom
document why leftWallVelocity does not need to be stateful, #77
bd657df
pixelzoom added a commit that referenced this issue May 9, 2024
@pixelzoom
restructure Studio tree for diffusion.model because of custom IOTypes, …
c624f04 
…#77
pixelzoom added a commit that referenced this issue May 9, 2024
@pixelzoom
add isSettingPhetioStateProperty checks, #77
59faeac
@pixelzoom pixelzoom mentioned this issue May 13, 2024
Closed
pixelzoom added a commit that referenced this issue May 13, 2024
@pixelzoom
add isSettingPhetioStateProperty checks, #77
1f621a5
pixelzoom added a commit that referenced this issue May 13, 2024
@pixelzoom
delete TODOs, #77
25efa87
pixelzoom added a commit that referenced this issue May 13, 2024
@pixelzoom
delete TODO, #77
79b852b
pixelzoom added a commit that referenced this issue May 13, 2024
@pixelzoom
note the type of serialization, #77
e04d25e
pixelzoom added a commit that referenced this issue May 13, 2024
@pixelzoom
use default toStateObject, #77
5d18097
pixelzoom added a commit that referenced this issue May 13, 2024
@pixelzoom
delete unnecessary defaultDeserializationMethod: 'applyState', #77
af317b4
pixelzoom added a commit that referenced this issue May 13, 2024
@pixelzoom
use ReferenceArrayIO and default applyState, #77
17c9699
This was referenced May 13, 2024
Closed
Closed
@pixelzoom
Copy link
Contributor Author

PhET-iO instrumentation is complete. Any additional work will be new features or change requests, to be tracked in other GitHub issues. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:phet-io
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom