-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PhET-iO instrumentation of sampling models #241
Comments
@arouinfar @Nancy-Salpepi @kathy-phet This is ready for review. Below is a summary of the relevant PhET-iO elements. Average Speed
Speed and KE histograms
Particle Flow Rate
|
In #235, serialization of the histograms was optimized. HistogramsModelIO now look like this. Rather than storing raw samples of speed and KE, the samples are immediately processed into "cumulative bins", then averaged later. This greatly reduces the amount of serialized data. |
@arouinfar and @Nancy-Salpepi noted a potential problem with restoring state for the Speed histogram, tracking in #261. @arouinfar @Nancy-Salpepi if everything else looks OK here, and the state schemas look reasonable, please close this issue. |
Looks good, closing. |
Related to #231 (PhET-iO instrumentation for particles) and #236 (PhET-iO support for data fluency) ...
The following things sample the particle system:
For each of these, the samples need to be stateful. For the elements that involve a fixed time period, the accumulated time must also be stateful.
The text was updated successfully, but these errors were encountered: