Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screen.js files are not converted to ES6 #40

Closed
Denz1994 opened this issue Dec 21, 2018 · 2 comments
Closed

Screen.js files are not converted to ES6 #40

Denz1994 opened this issue Dec 21, 2018 · 2 comments
Assignees
@Denz1994
Labels
dev:code-review

Comments

@Denz1994
Copy link
Contributor

Found during #29

Files such as Fractions-Mixed-Numbers/GameScreen.js are not ES6 ready. This is true for *Screen.js files in Fractions-Mixed-Numbers, Fractions-Intro, Fractions-Equality, and Build-A-Fraction. Is this something that should be taken care of now @jonathanolson, considering the common repo is converted to ES6?
jonathanolson added a commit to phetsims/build-a-fraction that referenced this issue Dec 26, 2018
@jonathanolson
Adding screen icons and converting to ES6, see phetsims/fractions-com…
7bc94cb 
…mon#40 and phetsims/fractions-common#30
jonathanolson added a commit to phetsims/build-a-fraction that referenced this issue Dec 27, 2018
@jonathanolson
Adding screen icons and converting to ES6, see phetsims/fractions-com…
53ef990 
…mon#40 and phetsims/fractions-common#30
jonathanolson added a commit to phetsims/fractions-equality that referenced this issue Dec 27, 2018
@jonathanolson
Adding screen icons and converting to ES6, see phetsims/fractions-com…
6eaf3cc 
…mon#40 and phetsims/fractions-common#30
jonathanolson added a commit to phetsims/fractions-intro that referenced this issue Dec 27, 2018
@jonathanolson
Adding screen icons and converting to ES6, see phetsims/fractions-com…
74532aa 
…mon#40 and phetsims/fractions-common#30
jonathanolson added a commit to phetsims/fractions-mixed-numbers that referenced this issue Dec 27, 2018
@jonathanolson
Adding screen icons and converting to ES6, see phetsims/fractions-com…
1712dce 
…mon#40 and phetsims/fractions-common#30
@jonathanolson
Copy link
Contributor

Yup, my mistake. Should be fixed now, can you verify?

@Denz1994
Copy link
Contributor Author

Denz1994 commented Jan 2, 2019

This looks good. Closing.

@Denz1994 Denz1994 closed this as completed Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Denz1994 Denz1994

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @Denz1994