Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Leak testing #39

Closed
Denz1994 opened this issue Dec 21, 2018 · 11 comments
Closed

Memory Leak testing #39

Denz1994 opened this issue Dec 21, 2018 · 11 comments
Assignees

Comments

@Denz1994
Copy link
Contributor

Reported during #29.

Does a heap comparison using Chrome Developer Tools indicate a memory leak?

Testing on macOS (10.13.6) + Chrome (71.0.3578.98) + incognito mode. Heap comparison shot in 15 minute intervals below.

Fractions intro:
image

@Denz1994 Denz1994 self-assigned this Dec 21, 2018
@Denz1994
Copy link
Contributor Author

Fractions - Equality
image

@Denz1994
Copy link
Contributor Author

Build-A-Fraction:
]image

@Denz1994
Copy link
Contributor Author

Fractions-Mixed-Numbers:
image

@Denz1994
Copy link
Contributor Author

Based on my experience doing previous memory test, I would have expected memory usage to plateau after 2hrs. But results seem inconsistant especially in Fractions-Mixed-Numbers and Build-A-Fraction.

There are some spikes in memory usage, and I believe those snapshots were taken when the sim was on a lab screen. I will do a long test at 30 min intervals and if the inconsitancy persist, commence memory leak testing on only the lab screens in the related sims.

@Denz1994 Denz1994 mentioned this issue Dec 21, 2018
@Denz1994
Copy link
Contributor Author

Denz1994 commented Jan 2, 2019

Testing on macOS (10.13.6) + Chrome (71.0.3578.98) + incognito mode. Heap comparison shot in 30 minute intervals below.

Note: Snapshot 13 to Snapshot 14 was taken with about an hour interval.

@Denz1994
Copy link
Contributor Author

Denz1994 commented Jan 2, 2019

Fractions Intro:
image

@Denz1994
Copy link
Contributor Author

Denz1994 commented Jan 2, 2019

Fractions - Equality
image

@Denz1994
Copy link
Contributor Author

Denz1994 commented Jan 2, 2019

Build-A-Fraction:
image

@Denz1994
Copy link
Contributor Author

Denz1994 commented Jan 2, 2019

Fractions-Mixed-Numbers:
image

@Denz1994
Copy link
Contributor Author

Denz1994 commented Jan 2, 2019

Based on the latest test this is looking like a slow memory leak. Total test time for the second test was roughly 8.5 hours and my browser didn't crash. This may not be specific to the lab screen as previously I thought because Fractions-Equality doesn't have a lab screen. Thoughts on what might be causing this slow leak @jonathanolson.

During code review (#29), there were some added REVIEW comments regarding dispose calls and unlinks to properties. Perhaps addressing these comments and commencing another memory test would be a good starting point. Turning over to @jonathanolson for added input and follow up.

@jonathanolson
Copy link
Contributor

Verified after 12 hours that there is no significant memory leak now. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants