Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Credits of Fractions sims #37

Closed
Denz1994 opened this issue Dec 19, 2018 · 7 comments
Closed

Update Credits of Fractions sims #37

Denz1994 opened this issue Dec 19, 2018 · 7 comments

Comments

@Denz1994
Copy link
Contributor

Related to #29.

Does a GitHub issue exist for tracking credits, to ensure that they are correct before publication?

All fractions-commmon related sims need their credits updated. I'm creating this issue to track this.

@jonathanolson
Copy link
Contributor

@amanda-phet or @ariel-phet what should the credits be for the main 4 sims? Also do credits need to change for fraction-matcher at all?

@amanda-phet
Copy link

QA credits will need to be added for fraction-matcher but otherwise they can stay the same. (@KatieWoe should communicate QA credits for all sims after all testing is done.)

Fractions-Intro
Ariel Paul (lead designer)
Jonathan Olson (developer)
Sam Reid (original developer)
Mike Dubson
Trish Loeblein
Amanda McGarry
Kathy Perkins

Fractions-Mixed-Numbers
Amanda McGarry (lead designer)
Jonathan Olson (developer)
Sam Reid (original developer)
Mike Dubson
Trish Loeblein
Ariel Paul
Kathy Perkins

Fractions-Equality
Ariel Paul (lead designer)
Jonathan Olson (developer)
Sam Reid (original developer)
Mike Dubson
Trish Loeblein
Amanda McGarry
Kathy Perkins

Build-a-Fraction
Ariel Paul (lead designer)
Jonathan Olson (developer)
Sam Reid (original developer)
Mike Dubson
Karina K. R. Hensberry
Trish Loeblein
Amanda McGarry
Kathy Perkins

jonathanolson added a commit to phetsims/build-a-fraction that referenced this issue Jan 15, 2019
jonathanolson added a commit to phetsims/fractions-equality that referenced this issue Jan 15, 2019
jonathanolson added a commit to phetsims/fractions-intro that referenced this issue Jan 15, 2019
jonathanolson added a commit to phetsims/fractions-mixed-numbers that referenced this issue Jan 15, 2019
@ariel-phet
Copy link

@jonathanolson is also adding @veillette and some of his students where appropriate.

jonathanolson added a commit to phetsims/fractions-mixed-numbers that referenced this issue Jan 16, 2019
jonathanolson added a commit to phetsims/fractions-intro that referenced this issue Jan 16, 2019
jonathanolson added a commit to phetsims/fractions-equality that referenced this issue Jan 16, 2019
jonathanolson added a commit to phetsims/build-a-fraction that referenced this issue Jan 16, 2019
@jonathanolson
Copy link
Contributor

Adjusted the credits above, I believe (besides QA) that they should be good.

@jonathanolson
Copy link
Contributor

Assigning to QA so this can be added before publication.

@KatieWoe
Copy link

KatieWoe commented Jan 29, 2019

QA for all add (if not there already): Steele Dalton, Megan Lai, Liam Mulhall, Laura Rea, Jacob Romero, Katie Woessner, and Kelly Wurtz

jonathanolson added a commit to phetsims/build-a-fraction that referenced this issue Jan 29, 2019
jonathanolson added a commit to phetsims/fractions-equality that referenced this issue Jan 29, 2019
jonathanolson added a commit to phetsims/fractions-intro that referenced this issue Jan 29, 2019
jonathanolson added a commit to phetsims/fractions-mixed-numbers that referenced this issue Jan 29, 2019
jonathanolson added a commit to phetsims/build-a-fraction that referenced this issue Jan 29, 2019
jonathanolson added a commit to phetsims/fractions-equality that referenced this issue Jan 29, 2019
jonathanolson added a commit to phetsims/fractions-intro that referenced this issue Jan 29, 2019
jonathanolson added a commit to phetsims/fractions-mixed-numbers that referenced this issue Jan 29, 2019
@jonathanolson
Copy link
Contributor

QA credits fixes pushed, applied to release branches, and deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants