Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stringTest=long component overlap #31

Closed
Denz1994 opened this issue Dec 17, 2018 · 2 comments
Closed

stringTest=long component overlap #31

Denz1994 opened this issue Dec 17, 2018 · 2 comments
Assignees
@Denz1994
Labels
dev:code-review type:i18n

Comments

@Denz1994
Copy link
Contributor

Related to #29:

Does the sim layout gracefully handle internationalized strings that are exceptionally long? (run with query parameter stringTest=long)

Here are some places to address.

Fractions-Intro: Intro Screen
image

Fractions-Intro: Game Screen
image

Fractions-Mixed-Numbers: Intro Screen
image

Fractions-Mixed-Numbers: Intro Screen
image

Fractions-Mixed-Numbers: Game Screen
image

Fractions-Mixed-Numbers: Game Screen (optional)
The next button width may be worth limiting despite not overlapping with any other component.
image
jonathanolson added a commit to phetsims/vegas that referenced this issue Dec 18, 2018
@jonathanolson
Improving the maxWidth handling for AllLevelsCompletedNode, see phets…
c534e1d 
…ims/fractions-common#31
jonathanolson added a commit that referenced this issue Dec 18, 2018
@jonathanolson
Adding maxWidths for every string, see #31
6588d35
@jonathanolson
Copy link
Contributor

All of this should be fixed up now, can you verify?

@Denz1994
Copy link
Contributor Author

Looking good. Closing.

@jonathanolson jonathanolson mentioned this issue Dec 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Denz1994 Denz1994

Labels
dev:code-review type:i18n
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @Denz1994