Added REVIEW comments #29

phetsims · Dec 24, 2018 · f2b0dc0 · f2b0dc0
1 parent a18d661
commit f2b0dc0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/js/building/model/ShapePiece.js b/js/building/model/ShapePiece.js
@@ -162,6 +162,7 @@ define( require => {
         return Vector2.ZERO;
       }
       else {
+        // REVIEW: 'let' instead of 'var'
         var positiveAngle = fraction.value * 2 * Math.PI;
 
         // Compute the centroid for a circular sector

diff --git a/js/game/model/FractionLevel.js b/js/game/model/FractionLevel.js
@@ -1468,7 +1468,10 @@ define( require => {
      * @returns {FractionChallenge}
      */
     static level5Numbers( levelNumber ) {
-      const shapeTargets = FractionLevel.targetsFromPartitions( choose( 3, ShapePartition.LIMITED_9_GAME_PARTITIONS.filter( partition => partition.length > 1 ) ), COLORS_3, d => sample( inclusive( 1, d - 1 ) ), FillType.SEQUENTIAL );
+      const shapeTargets = FractionLevel.targetsFromPartitions(
+        choose( 3, ShapePartition.LIMITED_9_GAME_PARTITIONS.filter( partition => partition.length > 1 ) ),
+        COLORS_3, d => sample( inclusive( 1, d - 1 ) ), FillType.SEQUENTIAL
+      );
       const pieceNumbers = FractionLevel.exactNumbers( shapeTargets.map( target => target.fraction ) );
 
       return FractionChallenge.createNumberChallenge( levelNumber, false, shapeTargets, pieceNumbers );
@@ -1649,7 +1652,10 @@ define( require => {
      * @returns {FractionChallenge}
      */
     static level10Numbers( levelNumber ) {
-      const shapeTargets = FractionLevel.targetsFromPartitions( choose( 4, ShapePartition.LIMITED_9_GAME_PARTITIONS ), COLORS_4, d => sample( inclusive( 1, 2 * d ) ), FillType.MIXED );
+      const shapeTargets = FractionLevel.targetsFromPartitions(
+        choose( 4, ShapePartition.LIMITED_9_GAME_PARTITIONS ),
+        COLORS_4, d => sample( inclusive( 1, 2 * d ) ), FillType.MIXED
+      );
       const pieceNumbers = FractionLevel.withMultipliedNumbers( shapeTargets.map( target => target.fraction ), 2, false );
 
       return FractionChallenge.createNumberChallenge( levelNumber, false, shapeTargets, pieceNumbers );