Added REVIEW comments regarding unlink() #29

phetsims · Dec 21, 2018 · 7787668 · 7787668
1 parent 317d3ed
commit 7787668
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 0 deletions.
diff --git a/js/building/model/ShapePiece.js b/js/building/model/ShapePiece.js
@@ -87,6 +87,7 @@ define( require => {
       this.dampedHarmonicTimeElapsed = 0;
       this.trueTargetRotation = 0;
 
+      // REVIEW: Does this property need an unlink?
       this.isUserControlledProperty.link( isUserControlled => {
         if ( isUserControlled ) {
           this.shadowProperty.value = 1;

diff --git a/js/building/view/NumberPieceNode.js b/js/building/view/NumberPieceNode.js
@@ -100,6 +100,8 @@ define( require => {
           options.dropListener && options.dropListener( wasTouch );
         }
       } );
+
+      // REVIEW: Does this need an unlink?
       this.dragListener.isUserControlledProperty.link( controlled => {
         numberPiece.isUserControlledProperty.value = controlled;
       } );

diff --git a/js/building/view/ShapePieceNode.js b/js/building/view/ShapePieceNode.js
@@ -146,6 +146,7 @@ define( require => {
           options.dropListener && options.dropListener( wasTouch );
         }
       } );
+      // REVIEW: Does this need an unlink?
       this.dragListener.isUserControlledProperty.link( controlled => {
         shapePiece.isUserControlledProperty.value = controlled;
       } );

diff --git a/js/game/view/FractionChallengeNode.js b/js/game/view/FractionChallengeNode.js
@@ -125,6 +125,8 @@ define( require => {
       this.levelCompleteListener = score => {
         this.levelCompleteNode.visible = score === this.challenge.targets.length;
       };
+
+      // REVIEW: Does this listener need an unlink?
       this.challenge.scoreProperty.link( this.levelCompleteListener );
 
       // layout

diff --git a/js/intro/view/EqualityLabScreenView.js b/js/intro/view/EqualityLabScreenView.js
@@ -91,6 +91,7 @@ define( require => {
           beakerIcon
         ]
       } );
+      // REVIEW: Does this need an unlink?
       model.representationProperty.link( representation => {
         circularIcon.visible = representation === IntroRepresentation.CIRCLE;
         horizontalIcon.visible = representation === IntroRepresentation.HORIZONTAL_BAR;
@@ -159,6 +160,7 @@ define( require => {
       multipliedFractionNode.centerY = bottomAlignY;
       multiplierSpinner.centerY = bottomAlignY;
 
+      // REVIEW: Does this need an unlink?
       model.representationProperty.link( () => {
         this.viewContainer.right = this.representationPanel.right;
       } );

diff --git a/js/lab/view/LabShapePanel.js b/js/lab/view/LabShapePanel.js
@@ -100,6 +100,7 @@ define( require => {
         boxContainer
       ];
 
+      // REVIEW: Does this need an unlink?
       this.representationProperty.link( representation => {
         this.pieBox.visible = representation === BuildingRepresentation.PIE;
         this.barBox.visible = representation === BuildingRepresentation.BAR;

diff --git a/js/matcher/view/LevelNode.js b/js/matcher/view/LevelNode.js
@@ -269,6 +269,7 @@ define( require => {
     };
 
     //show correct button depending on the previous actions
+    // REVIEW: Does this need an unlink?
     model.buttonStatusProperty.link( function updateButtonStatus( value ) {
       buttonOk.setVisible( value === 'ok' );
       buttonCheck.setVisible( value === 'check' );
@@ -293,19 +294,23 @@ define( require => {
       }
     } );
 
+    // REVIEW: Doc typo?
     //adjustion timer position if necessary
+    // REVIEW: Does this need an unlink?
     model.gameModel.isTimerProperty.link( function( isTimer ) {
       timeLabel.visible = isTimer;
       vBox.right = model.gameModel.width - margin;
     } );
 
     //update timer
+    // REVIEW: Does this need an unlink?
     model.timeProperty.link( function( newTime ) {
       timeLabel.text = StringUtils.format( timeNumberSecString, Util.toFixed( newTime, 0 ) );
       vBox.right = model.gameModel.width - margin;
     } );
 
     //update score
+    // REVIEW: Does this need an unlink?
     model.scoreProperty.link( function( newScore ) {
       scoreLabel.text = StringUtils.format( labelScoreString, newScore );
       vBox.right = model.gameModel.width - margin;

diff --git a/js/matcher/view/LevelsContainerNode.js b/js/matcher/view/LevelsContainerNode.js
@@ -108,6 +108,7 @@ define( require => {
 
     this.levelNodes = [];
 
+    // REVIEW: Does this need an unlink?
     model.currentLevelProperty.link( function( newLevel ) {
       if ( newLevel > 0 ) {
         //generate each node levelNode on demand, to make loading faster