Skip to content

Commit

Permalink
Added REVIEW comments #29
Browse files Browse the repository at this point in the history
Denz1994 committed Dec 21, 2018
1 parent 1a304ac commit 51ef9d7
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions js/building/model/ShapePiece.js
Original file line number Diff line number Diff line change
@@ -97,9 +97,12 @@ define( require => {
// Handle rotational animation towards a target (if any)
Property.multilink( [ this.isUserControlledProperty, this.targetRotationProperty ], ( isUserControlled, targetRotation ) => {
if ( isUserControlled ) {
// REVIEW: 'let' instead of 'var'
var currentRotation = this.rotationProperty.value;
this.trueTargetRotation = Animator.modifiedEndAngle( currentRotation, this.targetRotationProperty.value );

// REVIEW: 'let' instead of 'var'
// REVIEW: Documentation for these variables would be helpful, being they are only used below.
var damping = 1;
var force = 50;
this.dampedHarmonicTimeElapsed = 0;

0 comments on commit 51ef9d7

Please sign in to comment.