-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sonification #320
Comments
Even if we decide not to add UI sounds, shouldn't we still do this? I could be missing some nuance, but I thought the changes in #316 meant that we are using tambo for the cheering sound, so the audio toggle button is in the navbar. This is similar to sims with game sounds, but no other UI sounds, such as Balancing Act. |
The checklist items @samreid identified above have been addressed in the above commits. Over to @amanda-phet to review. I believe once this is approved we can go into dev testing. |
Everything is sounding good to me! I'll leave this open for QA to confirm everything has a sound, but I think it's good to go. |
Everything has a sound and the clapping sound is working well on the Net Force screen. |
When the dependency on vibe was removed in #316, the simulation picked up sound effects for checkboxes, buttons, and sliders.
@amanda-phet said:
@arouinfar commented:
So for this issue, I think we would need to:
There is also a proposal for a clickety-clack sound to indicate the speed the skateboard goes over the sidewalk cracks in #151.
@amanda-phet should this design + implementation work be done the current Region & Culture release?
The text was updated successfully, but these errors were encountered: