Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency for emf casing #147

Closed
samreid opened this issue Mar 27, 2024 · 1 comment
Closed

Consistency for emf casing #147

samreid opened this issue Mar 27, 2024 · 1 comment
Assignees

Comments

@samreid
Copy link
Member

samreid commented Mar 27, 2024

During #103 we observed this code in PickupCoil.ts:

    this._biggestAbsEmf = 0.0;

    // Check that maxEMFProperty is calibrated properly.
    if ( FELQueryParameters.calibrateEMF ) {
      this._emfProperty.lazyLink( () => this.calibrateMaxEMF() );
    }

    this.maxEMFProperty = new NumberProperty( options.maxEMF, {

We saw that some variables have Emf and some have EMF. We recommend consistency here.

@pixelzoom
Copy link
Contributor

The only variable I found was _biggestAbsEmf. I renamed it to largestAbsoluteEMF.

I like how you used "emf" in the issue title :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants