Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete sentence in Electron.ts documentation #137

Closed
samreid opened this issue Mar 27, 2024 · 2 comments
Closed

Incomplete sentence in Electron.ts documentation #137

samreid opened this issue Mar 27, 2024 · 2 comments

Comments

@samreid
Copy link
Member

samreid commented Mar 27, 2024

From #103, we observed this code

// Evaluate the quadratic to determine the electron's position relative to the segment.
// Use a different reusable Vector2 each time that curve.evaluate is called, so that
const coilSegment = this.coilSegments[ this.coilSegmentIndex ];
const returnValue = ( this.position === this.reusablePosition1 ) ? this.reusablePosition2 : this.reusablePosition1;
this.position = coilSegment.evaluate( this.coilSegmentPosition, returnValue );
which has an incomplete sentence in the documentation.

@samreid
Copy link
Member Author

samreid commented Mar 27, 2024

Note we subsequently identified a better approach in #141. After implementing #141, nothing more should be needed here.

pixelzoom added a commit that referenced this issue Mar 28, 2024
@pixelzoom
Copy link
Contributor

I fixed the comment anyway. I'll have a look at #141.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants